Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSharpGuidelinesAnalyzer and associated editorconfig values #145

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

rjmurillo
Copy link
Owner

No description provided.

@rjmurillo rjmurillo linked an issue Jul 6, 2024 that may be closed by this pull request
@rjmurillo rjmurillo requested a review from MattKotsenas July 6, 2024 20:50
@rjmurillo rjmurillo added dependencies Pull requests that update a dependency file releasable build labels Jul 6, 2024
Copy link

codeclimate bot commented Jul 6, 2024

Code Climate has analyzed commit a4ae63e and detected 433 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 433

View more on Code Climate.

@rjmurillo rjmurillo added this to the v0.2.0 milestone Jul 6, 2024
@rjmurillo rjmurillo enabled auto-merge (squash) July 6, 2024 20:51
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 95.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d5fe1a2) 460 425 92.39%
Head commit (a4ae63e) 460 (+0) 425 (+0) 92.39% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#145) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@rjmurillo rjmurillo merged commit ac8bde6 into main Jul 6, 2024
7 of 8 checks passed
@rjmurillo rjmurillo deleted the 139-remove-csharpguidelinesanalyzer branch July 6, 2024 21:04
MattKotsenas added a commit to MattKotsenas/moq.analyzers that referenced this pull request Oct 24, 2024
MattKotsenas added a commit that referenced this pull request Oct 25, 2024
Fixes #90 

- The AVXXXX rules were removed as part of #145, but some of the
suppressions were left behind. Remove them.
- The only instance of S2583 is dead code (guards above make it
impossible). Remove it.
- S2589 is still unclear to me, but it seems silly to keep a bug open
for one suppression that we can revisit whenever we touch the code next.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dependencies Pull requests that update a dependency file releasable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CSharpGuidelinesAnalyzer
2 participants