Update SDK to get newer version of Source Link

[MattKotsenas]

Update to the .NET 9 RC SDK. This brings in a new version of the Source Link packages, which then allows us to remove our manual setting of $(RepositoryBranch).

Updating the SDK enables NuGet audit, so I added a transitive pin for System.Formats.Asn1.

Updating the SDK also introduces new analyzer rules, so I updated SquiggleCop baselines.

Summary by CodeRabbit

• New Features

  • Introduced new diagnostic rules to enhance code quality across maintainability, performance, reliability, usage, and style categories.
  • Added specific guidelines to improve best practices for developers.

• Bug Fixes

  • Removed unnecessary complexity in build configuration to streamline processes and reduce potential discrepancies.

• Documentation

  • Updated existing rules for clarity and precision in the codebase documentation.

[coderabbitai]

Walkthrough

Walkthrough

The pull request introduces several changes across multiple files, including the removal of the SetRepositoryBranch target from the Reproducible.targets file, an upgrade of the SDK version in the global.json file, and the addition of new diagnostic rules in the SquiggleCop.Baseline.yaml files. The changes aim to simplify the build process, update SDK dependencies, and enhance code quality through improved analysis rules.

Changes

File	Change Summary
build/targets/reproducible/Reproducible.targets	Removed the SetRepositoryBranch target, simplifying the handling of the RepositoryBranch property.
global.json	Updated the SDK version from 8.0.400 to 9.0.100-rc.1.24452.12.
Directory.Packages.props	Added a new package version declaration for System.Formats.Asn1 version 8.0.1.
src/Moq.Analyzers/SquiggleCop.Baseline.yaml	Added multiple new diagnostic rules across various categories to enhance code analysis.
tests/Moq.Analyzers.Benchmarks/SquiggleCop.Baseline.yaml	Added multiple new diagnostic rules similar to those in src/Moq.Analyzers/SquiggleCop.Baseline.yaml.
tests/Moq.Analyzers.Test/SquiggleCop.Baseline.yaml	Added multiple new diagnostic rules similar to those in src/Moq.Analyzers/SquiggleCop.Baseline.yaml.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 4d241db and d821ac0.

Files selected for processing (4)

• src/Moq.Analyzers/SquiggleCop.Baseline.yaml (6 hunks)
• src/tools/PerfDiff/SquiggleCop.Baseline.yaml (6 hunks)
• tests/Moq.Analyzers.Benchmarks/SquiggleCop.Baseline.yaml (6 hunks)
• tests/Moq.Analyzers.Test/SquiggleCop.Baseline.yaml (6 hunks)

Additional comments not posted (25)

src/Moq.Analyzers/SquiggleCop.Baseline.yaml (11)

76-76: Looks good!

The addition of rule CA1514 to flag redundant length arguments is approved. This will help improve code maintainability.

---

77-77: Looks good!

The addition of rule CA1515 to suggest making public types internal where possible is approved. This will help limit the public API surface and improve encapsulation.

---

153-153: Looks good!

The addition of rule CA1871 to avoid passing nullable structs to ArgumentNullException.ThrowIfNull is approved. This will help improve performance by avoiding unnecessary checks.

---

154-154: Looks good!

The addition of rule CA1872 to prefer using Convert.ToHexString and Convert.ToHexStringLower over BitConverter.ToString call chains is approved. This will help improve performance for hex string conversions.

---

171-171: Looks good!

The addition of rule CA2022 to flag inexact reads with Stream.Read is approved. This will help improve reliability by avoiding potential data integrity issues.

---

215-215: Looks good!

The addition of rule CA2262 to ensure MaxResponseHeadersLength is set properly is approved. This is important for correct HTTP response handling.

---

216-216: Looks good!

The addition of rule CA2263 to prefer generic overloads when the type is known is approved. This will enhance type safety and performance.

---

217-217: Looks good!

The addition of rule CA2264 to avoid passing non-nullable values to ArgumentNullException.ThrowIfNull is approved. This will prevent potential runtime exceptions.

---

218-218: Looks good!

The addition of rule CA2265 to avoid comparing Span<T> to null or default is approved. This will prevent misleading results and potential bugs.

---

306-306: Looks good!

The title change for rule CA5402 to remove the trailing space after "IV" is approved.

---

432-432: Looks good!

The addition of rule IDE0330 to promote the use of System.Threading.Lock is approved. This aligns with best practices for thread safety and synchronization.

src/tools/PerfDiff/SquiggleCop.Baseline.yaml (3)

76-76: Looks good!

The addition of rule CA1514 for avoiding redundant length arguments makes sense to improve code maintainability.

---

77-77: Consider the project's API goals before enabling this rule.

The new rule CA1515 suggests making public types internal. While this can improve maintainability by reducing the public API surface, it could also impact the project's API goals. Ensure enabling this rule aligns with the desired public API before enforcing it.

---

306-306: Good catch!

Removing the extra space in CA5402's title is a nice touch to keep things clean. No concerns with this minor edit.

tests/Moq.Analyzers.Benchmarks/SquiggleCop.Baseline.yaml (1)

Line range hint 1-1268: Changes look good!

The addition of the new analyzer rules across maintainability, performance, reliability, usage, security, and style categories will help improve the overall code quality. The chosen severity levels seem appropriate based on each rule's potential impact. The minor title modification also looks fine.

Great job enhancing the analyzer rule set!

tests/Moq.Analyzers.Test/SquiggleCop.Baseline.yaml (10)

76-76: LGTM!

The addition of rule CA1514 to flag redundant length arguments looks good. It will help improve code maintainability.

---

77-77: Looks good!

The addition of rule CA1515 to suggest making public types internal where possible is approved. Having it disabled by default is sensible.

---

153-153: Approved.

Adding rule CA1871 to flag passing nullable structs to ArgumentNullException.ThrowIfNull is approved. It's a good performance rule to have.

---

154-154: LGTM!

The addition of rule CA1872 to recommend using Convert.ToHexString/ToHexStringLower over BitConverter.ToString call chains is approved. It's a good performance optimization rule.

---

171-171: Approved.

Adding rule CA2022 to flag inexact reads with Stream.Read is approved. It's an important reliability rule and setting the effective severity to Error is appropriate.

---

215-215: Looks good!

The addition of rule CA2262 to ensure MaxResponseHeadersLength is set properly is approved. It's a good usage rule to have.

---

216-216: Approved.

Adding rule CA2263 to prefer generic overloads when the type is known is approved. It's a useful rule to promote good usage practices.

---

217-217: LGTM!

The addition of rule CA2264 to flag passing non-nullable values to ArgumentNullException.ThrowIfNull is approved. It's an important rule to catch incorrect usages and setting the effective severity to Error is fitting.

---

218-218: Approved.

Adding rule CA2265 to flag comparing Span to null or default is approved. It's an important rule to catch incorrect usages and setting the effective severity to Error is suitable.

---

306-306: Title correction looks good.

The extra space at the end of the title for rule CA5402 has been removed. This minor textual correction improves clarity without changing the meaning of the rule.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codeclimate]

Code Climate has analyzed commit d821ac0 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

View more on Code Climate.