Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package dependencies and don't publish analyzer as a lib #49

Merged

Conversation

MattKotsenas
Copy link
Collaborator

Fixes #31.

Address two related issues:

  1. Don't pack the analyzer in the lib/ folder, as that makes it an input to the user's compilation
  2. Because there is no lib, suppress the dependency on .NET Standard 2.0, as that's an implementation detail of the analyzer and not a requirement of the package.

To do that I also removed the <NoPackageAnalysis>, which disables all package analysis, and instead fixed the raised issues via <IncludeBuildOutput> and <SuppressDependenciesWhenPacking>.

@rjmurillo rjmurillo self-requested a review June 4, 2024 15:32
@rjmurillo rjmurillo added this to the 0.1.X milestone Jun 4, 2024
@rjmurillo rjmurillo merged commit 1908bb6 into rjmurillo:master Jun 4, 2024
3 checks passed
@MattKotsenas MattKotsenas deleted the bugfix/package-dependencies branch June 6, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package follows best practices for analyzer structure
2 participants