Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gif for gymnasium env #467

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Conversation

JulienT01
Copy link
Collaborator

@JulienT01 JulienT01 commented Jul 8, 2024

Description

Allow the save as Gif for gymnasium env (make_gym) : #453

Checklist

  • My code follows the style guideline
    To check :
    black --check examples rlberry *py
    flake8 --select F401,F405,D410,D411,D412 --exclude=rlberry/check_packages.py --per-file-ignores="init.py:F401",
  • I have commented my code, particularly in hard-to-understand areas,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works,
  • New and existing unit tests pass locally with my changes,
  • If updated the changelog if necessary,
  • I have set the label "ready for review" and the checks are all green.

Copy link

github-actions bot commented Jul 8, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

Copy link

github-actions bot commented Jul 8, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

Copy link

github-actions bot commented Jul 8, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@JulienT01 JulienT01 requested a review from TimotheeMathieu July 8, 2024 13:04
Copy link

github-actions bot commented Jul 8, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

docs/basics/userguide/visualization.md Outdated Show resolved Hide resolved
docs/basics/userguide/visualization.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 8, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@TimotheeMathieu TimotheeMathieu merged commit 8c9272c into rlberry-py:main Jul 11, 2024
12 checks passed
@JulienT01 JulienT01 deleted the gif_for_gym branch July 12, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants