Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call git checkout when it is not head of the working copy #116

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

stephane-caron
Copy link
Member

Closes #115

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11896209659

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.423%

Totals Coverage Status
Change from base Build 11746909263: 0.0%
Covered Lines: 945
Relevant Lines: 970

💛 - Coveralls

@stephane-caron
Copy link
Member Author

stephane-caron commented Nov 18, 2024

Confirming that, with this change, I'm getting:

$ parallel -i -j 8 python -c 'from robot_descriptions import fr3_mj_description; print({}, fr3_mj_description.MJCF_PATH)' -- 1 2 3 4 5 6 7 8
2 ~/.cache/robot_descriptions/mujoco_menagerie/franka_fr3/fr3.xml
3 ~/.cache/robot_descriptions/mujoco_menagerie/franka_fr3/fr3.xml
1 ~/.cache/robot_descriptions/mujoco_menagerie/franka_fr3/fr3.xml
5 ~/.cache/robot_descriptions/mujoco_menagerie/franka_fr3/fr3.xml
6 ~/.cache/robot_descriptions/mujoco_menagerie/franka_fr3/fr3.xml
4 ~/.cache/robot_descriptions/mujoco_menagerie/franka_fr3/fr3.xml
7 ~/.cache/robot_descriptions/mujoco_menagerie/franka_fr3/fr3.xml
8 ~/.cache/robot_descriptions/mujoco_menagerie/franka_fr3/fr3.xml

@stephane-caron stephane-caron enabled auto-merge (rebase) November 18, 2024 16:05
@stephane-caron stephane-caron merged commit 985878a into main Nov 18, 2024
15 checks passed
@stephane-caron stephane-caron deleted the fix/parallel_clone branch November 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Race condition when importing the same description in parallel
2 participants