Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Menagerie models. #61

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Add more Menagerie models. #61

merged 5 commits into from
Mar 26, 2024

Conversation

kevinzakka
Copy link
Contributor

No description provided.

stephane-caron
stephane-caron reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@stephane-caron stephane-caron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @kevinzakka for linking these!

Some checks don't pass but they will be easy to fix. I've listed them in comments.

robot_descriptions/allegro_hand_mj_description.py Show resolved Hide resolved
robot_descriptions/aloha_mj_description.py Show resolved Hide resolved
robot_descriptions/stretch_mj_description.py Outdated Show resolved Hide resolved
@kevinzakka
Copy link
Contributor Author

Sorry Stéphane, I should have run the tests 😅 Will get to this asap.

@kevinzakka
Copy link
Contributor Author

Done, thanks for the review and awesome repo @stephane-caron.

@kevinzakka
Copy link
Contributor Author

Pushing fixes as slow tox runs 😅

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8441790144

Details

  • 58 of 58 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 98.633%
Totals Coverage Status
Change from base Build 8005527766: 0.09%
Covered Lines: 938
Relevant Lines: 951
💛 - Coveralls

@stephane-caron stephane-caron merged commit 60e17bc into robot-descriptions:main Mar 26, 2024
11 checks passed
@stephane-caron
Copy link
Member

And it is merged, thank you for this contribution 😃

@kevinzakka kevinzakka deleted the more-mujoco-models branch March 27, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephane-caron stephane-caron stephane-caron left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinzakka @coveralls @stephane-caron