Improve CD workflow #888
Merged
Improve CD workflow #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters and evenly pass to the definition task
| - name: Download Parameter Store Values | ||
| id: ssm-download | ||
| run: | | ||
| PARAMETERS_JSON=$(aws ssm describe-parameters --query "Parameters[?contains(Name, 'backend')].{Name:Name,ARN:ARN}" --output json | jq -c '.') |
There was a problem hiding this comment.
Shoulds we use contains or maybe only check if it starts with that key? Just thinking that maybe some other keys are named backend and we end up pulling them as well
There was a problem hiding this comment.
I use contains because the name convention that Devops use is project_name/(backend|frontend)/var_name and I think is a good way to search, which scenery do you think could be retrieve keys that I don't want
santib
reviewed
Dec 9, 2024
santib
reviewed
Dec 9, 2024
santib
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board:
Description:
backenddefined parameters in AWS Parameter Store, format them, and pass them to the definition task.Notes:
Tasks:
Risk:
Preview: