Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed C++20 warning implicit capture of this in lambda #41

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

AiVerisimilitude
Copy link
Contributor

Fixes a warning issued by C++20 for the implicit capture of this when using [ = ]. Since [=, this] is not available yet in C++17 I just explicitly capture the this pointer and any other variables by copy.

Signed-off-by: Guilherme Rodrigues <guilherme.rodrigues@ait.ac.at>
@AiVerisimilitude AiVerisimilitude requested a review from a team as a code owner February 5, 2024 09:13
@AiVerisimilitude AiVerisimilitude requested review from emersonknapp and christophebedard and removed request for a team February 5, 2024 09:13
Copy link
Member

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AiVerisimilitude Thanks for the PR. LGTM.

@MichaelOrlov
Copy link
Member

Gist: https://gist.githubusercontent.com/MichaelOrlov/66b38a4ad0d396c683966abdd799b2f1/raw/44465cfe18527d1697e4495f79ede1b4e3d6b462/ros2.repos
BUILD args: --packages-above-and-dependencies keyboard_handler
TEST args: --packages-above keyboard_handler
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/13238

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 1a64e1f into ros-tooling:rolling Feb 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants