Make error console sizing constant across base and bslib apps #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpsievert, I'd be curious if there's a bootstrap variable or approach that we could take here for making the sizing more responsive. I just hard-coded a font-size to get around the difference between old bootstrap and the newer bslib bootstrap versions. |
…s so console is consistantly sized across apps that set the body font size.
jcheng5
force-pushed
the
error-console-font-size-update
branch
from
2d0ef4e to
fd6dd31
Compare
|
I don't think of the error console as part of the UI, nor subject to the app author's preferences in terms of bslib or other CSS customizations--I think it's totally OK for it to be hard-coded to a px size. |
jcheng5
approved these changes
Dec 14, 2023
jcheng5
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the error console appeared in an app using bslib it was comically large. This was due to the original console being designed with rem units for sizing and base shiny using 14px as the base font size. The bootstrap that bslib brings in has upped that size to 16px (in keeping with standards) and as a result, the error console got larger accordingly.
This PR updates this so that we use hard-coded font sizes instead. The main flaw is that the console does not correspond to zooms done by the user on the font size. However, we already break that a bit by hard-coding a font size on the body so it's a reasonable tradeoff.