Item View - Change value from cents to dollars #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cielf
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Hey @ZahBenjamin,
Welcome aboard!
We need a slight format change to be able to put this through.
Thanks!
| @@ -204,7 +204,7 @@ | |||
| expect(response.body).to include('Category') | |||
| expect(response.body).to include('CURRENTCATEGORY') | |||
| expect(response.body).to include('Value Per Item') | |||
| expect(response.body).to include('20000') | |||
| expect(response.body).to include('$200.0') | |||
There was a problem hiding this comment.
Dollar currency is always shown with two decimal places -- so I would expect this to be $200.00, not merely $200.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4790
Description
Change value from cents to dollars in item view
Type of change
How Has This Been Tested?
To test run the rspec file spec/requests/iitems_requests_spec.rb