Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 7.1 #4121

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Upgrade to Rails 7.1 #4121

merged 1 commit into from
Jan 18, 2024

Conversation

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18ddd37) 98.73% compared to head (2c0ba6c) 96.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4121      +/-   ##
==========================================
- Coverage   98.73%   96.98%   -1.76%     
==========================================
  Files         336      336              
  Lines        7431     7487      +56     
==========================================
- Hits         7337     7261      -76     
- Misses         94      226     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins segiddins force-pushed the segiddins/rails-7-1 branch from 6f0930b to 0810b4e Compare October 19, 2023 17:31
@segiddins segiddins force-pushed the segiddins/rails-7-1 branch 3 times, most recently from a8f8f81 to 38a16f5 Compare November 13, 2023 22:16
@segiddins segiddins force-pushed the segiddins/rails-7-1 branch 2 times, most recently from 8de0b71 to 844cddf Compare December 14, 2023 05:43
@segiddins segiddins force-pushed the segiddins/rails-7-1 branch 3 times, most recently from 58d7989 to 1cd01df Compare December 16, 2023 05:04
@segiddins segiddins force-pushed the segiddins/rails-7-1 branch 2 times, most recently from 8fd5843 to 6d6a7ee Compare December 29, 2023 19:36
@segiddins segiddins force-pushed the segiddins/rails-7-1 branch from 6d6a7ee to da231a5 Compare January 9, 2024 16:38
@segiddins segiddins force-pushed the segiddins/rails-7-1 branch from da231a5 to 2c0ba6c Compare January 16, 2024 19:51
@segiddins segiddins changed the title [WIP] Rails 7.1 Upgrade to Rails 7.1 Jan 16, 2024
@segiddins segiddins marked this pull request as ready for review January 16, 2024 19:56
@segiddins segiddins requested review from martinemde and simi January 16, 2024 19:56
Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good. Maybe mark secrets fix as TODO? Seems like it's too big a fix for this upgrade.

@@ -1,3 +1,4 @@
# DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

@segiddins segiddins merged commit 9c495ca into master Jan 18, 2024
15 of 16 checks passed
@segiddins segiddins deleted the segiddins/rails-7-1 branch January 18, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants