-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Rails 7.1 #4121
Upgrade to Rails 7.1 #4121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4121 +/- ##
==========================================
- Coverage 98.73% 96.98% -1.76%
==========================================
Files 336 336
Lines 7431 7487 +56
==========================================
- Hits 7337 7261 -76
- Misses 94 226 +132 ☔ View full report in Codecov by Sentry. |
6f0930b
to
0810b4e
Compare
a8f8f81
to
38a16f5
Compare
38a16f5
to
b146215
Compare
8de0b71
to
844cddf
Compare
58d7989
to
1cd01df
Compare
8fd5843
to
6d6a7ee
Compare
6d6a7ee
to
da231a5
Compare
da231a5
to
2c0ba6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems good. Maybe mark secrets fix as TODO? Seems like it's too big a fix for this upgrade.
@@ -1,3 +1,4 @@ | |||
# DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
?
still a work in progress. Waiting on:
broadcast
for classActiveSupport::Logger
on rails 7.1.0 reidmorrison/rails_semantic_logger#191