chore: add campaign object support in web pixel events #3973
Conversation
|
Allure Test reports for this run are available at:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore.redis.support.shopify.pixel #3973 +/- ##
====================================================================
Coverage ? 90.74%
====================================================================
Files ? 623
Lines ? 32555
Branches ? 7728
====================================================================
Hits ? 29541
Misses ? 2755
Partials ? 259 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
While these are the standard parameters, there can be custom UTM values like utm_xyz. We should support them too.
There was a problem hiding this comment.
@saikumarrs can they be transformed in similar way by just removing utm_ prefix ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Got it. Let me get this too
There was a problem hiding this comment.
addressed @saikumarrs
|
Allure Test reports for this run are available at: |
|
yashasvibajpai
merged commit 7f57e45
into
chore.redis.support.shopify.pixel
| const campaignObjectSourceKeys = campaignObjectMappings.flatMap( | ||
| (mapping) => mapping.sourceKeys, | ||
| ); | ||
| url.searchParams.forEach((value, key) => { |
There was a problem hiding this comment.
Is it not forEach((key, value) ?
There was a problem hiding this comment.
no, campaignParams[key] will get campaign { } keys, and value will be the utm values in the href
What are the changes introduced in this PR?
Add campaign object support in web pixel events similar to the campaign object in JS SDK
What is the related Linear task?
Resolves INT-3028
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.