fix: fixing mismatch of schedule field value in clicksend destination #3975
Conversation
… due to different timezone
| let defaultCampaignScheduleInt = parseInt(defaultCampaignSchedule, 10); | ||
| if (Number.isNaN(defaultCampaignScheduleInt)) { | ||
| defaultCampaignScheduleInt = 0; | ||
| } |
There was a problem hiding this comment.
@krishna2020 Should we throw error here? We should throw error ideally. I tested the API locally, We are getting successful response for any value for schedule. As per the destination doc . It should be in Unix format.
There was a problem hiding this comment.
@manish339k Can this be a random value? What is the UI here? Does the frontend limit the user to add only a number or any string?
There was a problem hiding this comment.
throwing error may cause problem for the existing destinations, if they have added some random value there.
There was a problem hiding this comment.
@vinayteki95 in frontend, ui does not restrict from entering any random value. it can be string.
There was a problem hiding this comment.
@manish339k In that case, let's not throw an error but before defaulting to 0 let try to clean up the string.
Cases like "2 " or " 10" (spaces around the value) can still be legitimate but a mistake from the user's side. Do cater for any other scenarios like this.
|
Allure Test reports for this run are available at: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3975 +/- ##
========================================
Coverage 90.75% 90.75%
========================================
Files 622 622
Lines 32516 32519 +3
Branches 7718 7719 +1
========================================
+ Hits 29511 29514 +3
Misses 2749 2749
Partials 256 256 ☔ View full report in Codecov by Sentry. |
|
What are the changes introduced in this PR?
there was a bug in the method where we are calculating the schedule by adding integer and string, due to this schedule iwas getting calculated wrongly. this PR fixes that issue.
What is the related Linear task?
Resolves INT-3107
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.