Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test bug #22

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Unit test bug #22

merged 1 commit into from
Sep 5, 2024

Conversation

cezar-r
Copy link
Contributor

@cezar-r cezar-r commented Sep 4, 2024

Issue #, if available:

Description of changes:
Ported changes from first patch
Created unit tests for api/handlers/image/load.go and internal/service/image/load.go

Testing done:
Passed all unit and e2e tests

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cezar-r cezar-r force-pushed the unit-test-bug branch 2 times, most recently from e068bbb to a2c932a Compare September 4, 2024 22:09
Copy link
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please see my comments. Also please update your commit message to better description of this change.

api/handlers/image/load_test.go Outdated Show resolved Hide resolved
internal/service/image/load.go Show resolved Hide resolved
internal/service/image/load_test.go Outdated Show resolved Hide resolved
internal/service/image/tmp/tmp.txt Outdated Show resolved Hide resolved
api/handlers/image/load.go Show resolved Hide resolved
internal/service/image/load.go Show resolved Hide resolved
internal/service/image/load_test.go Outdated Show resolved Hide resolved
internal/service/image/load_test.go Outdated Show resolved Hide resolved
api/handlers/image/load_test.go Outdated Show resolved Hide resolved
internal/service/image/load.go Outdated Show resolved Hide resolved
internal/service/image/load_test.go Outdated Show resolved Hide resolved
…it tests for load handler and service methods

Signed-off-by: Cezar Rata <ceradev@amazon.com>
Copy link
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cezar-r cezar-r merged commit df31cb6 into runfinch:main Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants