-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test bug #22
Merged
Merged
Unit test bug #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezar-r
force-pushed
the
unit-test-bug
branch
2 times, most recently
from
September 4, 2024 22:09
e068bbb
to
a2c932a
Compare
henry118
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please see my comments. Also please update your commit message to better description of this change.
coderbirju
reviewed
Sep 4, 2024
cezar-r
force-pushed
the
unit-test-bug
branch
from
September 5, 2024 17:55
a2c932a
to
380e6e1
Compare
henry118
reviewed
Sep 5, 2024
…it tests for load handler and service methods Signed-off-by: Cezar Rata <ceradev@amazon.com>
cezar-r
force-pushed
the
unit-test-bug
branch
from
September 5, 2024 18:50
380e6e1
to
2716b3a
Compare
henry118
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Ported changes from first patch
Created unit tests for
api/handlers/image/load.go
andinternal/service/image/load.go
Testing done:
Passed all unit and e2e tests
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.