Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement container restart API #23

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

cezar-r
Copy link
Contributor

@cezar-r cezar-r commented Sep 5, 2024

Issue #, if available:

Description of changes:
Ported changes from the second patch in the internal repo.

Testing done:
Passed all unit and e2e tests

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju
Copy link
Contributor

LGTM
Nit: maybe change the commit message to something similar to the style the team follows.

@cezar-r cezar-r changed the title Ported changes from internal 'implement container restart API' commit Port 'implement container restart API' patch Sep 5, 2024
@henry118
Copy link
Member

henry118 commented Sep 6, 2024

@cezar-r Mind rebase your PR on the latest code?

@cezar-r cezar-r force-pushed the container-restart branch 2 times, most recently from c4086fd to 96cba95 Compare September 6, 2024 16:58
@cezar-r cezar-r changed the title Port 'implement container restart API' patch feat: Port 'implement container restart API' patch Sep 6, 2024
Signed-off-by: Cezar Rata <ceradev@amazon.com>
@pendo324 pendo324 changed the title feat: Port 'implement container restart API' patch feat: implement container restart API Sep 6, 2024
@henry118 henry118 merged commit 5d9b1e0 into runfinch:main Sep 6, 2024
8 checks passed
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants