Remove rust-analyzer.cargo.sysrootQueryMetadata config again
#18788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
push-zxystwnotuvq
branch
from
0ee83ce to
a1f3b69
Compare
Veykril
commented
Dec 29, 2024
| ); | ||
| let mut sysroot = | ||
| Sysroot::new(project_json.sysroot.clone(), project_json.sysroot_src.clone()); | ||
| sysroot.load_workspace(&SysrootSourceWorkspaceConfig::Stitched); |
There was a problem hiding this comment.
Notable behavior change is here, we only stitch the sourceroot workspace for rust-project.json as we cannot assume a cargo to be present here. Ultimately, rust-project.json should supply the stitched sysroot workspace.
|
Ideally the rust-project.json will actually list the sysroot workspace (that is, it provides a stitched one), so that will need some adjustments to the json format. |
|
A thought for a follow up to this PR, we should be able to cache the fetched sysroot and re-use it between multiple workspaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18590