Merge pull request #31 from rxdi/jekozyra/update-passing-success-status

fix(createVirtualSymlink): pass success status to all calls to exitHandler
rxdi · Dec 11, 2021 · b7a674d · b7a674d
2 parents 073c54a + d9ff6b7
commit b7a674d
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 57 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,98 +1,66 @@
 ## [0.7.72](https://github.com/rxdi/firelink/compare/v0.7.71...v0.7.72) (2021-12-11)
 
-
 ### Bug Fixes
 
-* **package.json:** added mkdir for binaries since the build was not working ([62036d9](https://github.com/rxdi/firelink/commit/62036d956afa0b5f8aba34ca922bbb4189423ccc))
-
-
+- **package.json:** added mkdir for binaries since the build was not working ([62036d9](https://github.com/rxdi/firelink/commit/62036d956afa0b5f8aba34ca922bbb4189423ccc))
 
 ## [0.7.71](https://github.com/rxdi/firelink/compare/v0.7.70...v0.7.71) (2021-12-11)
 
-
 ### Bug Fixes
 
-* **README:** changed link to lead to latest binary ([26c152c](https://github.com/rxdi/firelink/commit/26c152c97fb85d104f9edeef39999a999c6bc4fe))
-
+- **README:** changed link to lead to latest binary ([26c152c](https://github.com/rxdi/firelink/commit/26c152c97fb85d104f9edeef39999a999c6bc4fe))
 
 ### Features
 
-* **release:** release process is only triggered when tag is created ([2529635](https://github.com/rxdi/firelink/commit/25296357961d6c3d087035f394d111896057eaf4))
-
-
+- **release:** release process is only triggered when tag is created ([2529635](https://github.com/rxdi/firelink/commit/25296357961d6c3d087035f394d111896057eaf4))
 
 ## [0.7.70](https://github.com/rxdi/firelink/compare/v0.7.69...v0.7.70) (2021-12-11)
 
-
-
 ## [0.7.69](https://github.com/rxdi/firelink/compare/v0.7.68...v0.7.69) (2021-12-11)
 
-
-
 ## [0.7.68](https://github.com/rxdi/firelink/compare/v0.7.67...v0.7.68) (2021-12-11)
 
-
 ### Bug Fixes
 
-* **binaries:** release for binaries using github action ([1afda49](https://github.com/rxdi/firelink/commit/1afda49d893bd1ad14ade61bdfa87cd984257933))
-
-
+- **binaries:** release for binaries using github action ([1afda49](https://github.com/rxdi/firelink/commit/1afda49d893bd1ad14ade61bdfa87cd984257933))
 
 ## [0.7.67](https://github.com/rxdi/firelink/compare/v0.7.66...v0.7.67) (2021-12-11)
 
-
-
 ## [0.7.66](https://github.com/rxdi/firelink/compare/v0.7.65...v0.7.66) (2021-12-11)
 
-
-
 ## [0.7.65](https://github.com/rxdi/firelink/compare/v0.7.64...v0.7.65) (2021-12-11)
 
-
 ### Features
 
-* **binaries:** trying to upload binaries to release... ([ad16d33](https://github.com/rxdi/firelink/commit/ad16d33ed52156602b79ab139307ef936e757253))
-
-
+- **binaries:** trying to upload binaries to release... ([ad16d33](https://github.com/rxdi/firelink/commit/ad16d33ed52156602b79ab139307ef936e757253))
 
 ## [0.7.64](https://github.com/rxdi/firelink/compare/v0.7.63...v0.7.64) (2021-12-11)
 
-
 ### Features
 
-* **binaries:** release for binaries version 2 ([ded727e](https://github.com/rxdi/firelink/commit/ded727e64374113efac033eeb0e5b6b55b6205e6))
-
-
+- **binaries:** release for binaries version 2 ([ded727e](https://github.com/rxdi/firelink/commit/ded727e64374113efac033eeb0e5b6b55b6205e6))
 
 ## [0.7.63](https://github.com/rxdi/firelink/compare/v0.7.62...v0.7.63) (2021-12-11)
 
-
 ### Features
 
-* **binaries:** added a github action to release binaries based on tags ([5620385](https://github.com/rxdi/firelink/commit/5620385eff79856c70ef79e1feeea98927332598))
-
-
+- **binaries:** added a github action to release binaries based on tags ([5620385](https://github.com/rxdi/firelink/commit/5620385eff79856c70ef79e1feeea98927332598))
 
 ## [0.7.62](https://github.com/rxdi/firelink/compare/017f8ee90d8b7eb26e5150fb963c2870cd4cce49...v0.7.62) (2021-12-09)
 
-
 ### Bug Fixes
 
-* **Dependencies:** https://github.com/rxdi/firelink/pull/3 ([017f8ee](https://github.com/rxdi/firelink/commit/017f8ee90d8b7eb26e5150fb963c2870cd4cce49))
-* **exitHandler:** added await inside create-virtual-symlink ([0b83f78](https://github.com/rxdi/firelink/commit/0b83f78f68ef1da8dd66f2a85a35298383271566))
-* **main:** when firebase crashes it is wrapped inside try catch causing to silend build fails ([9445747](https://github.com/rxdi/firelink/commit/944574740fbcb534540075b3b12d9bd8d982f9b3))
-* **packages:** on windows native fs introduced since the rsync behaviour differs ([d5b0bb4](https://github.com/rxdi/firelink/commit/d5b0bb491c14dc8bd635ccff5ca52bd63eefc72a))
-* **yarn:** version missmatch and wrong generated yarn.lock removed since we have package.lock.json ([7e0fce9](https://github.com/rxdi/firelink/commit/7e0fce993816629210f9abc1bab4961edc58d415))
-
+- **Dependencies:** https://github.com/rxdi/firelink/pull/3 ([017f8ee](https://github.com/rxdi/firelink/commit/017f8ee90d8b7eb26e5150fb963c2870cd4cce49))
+- **exitHandler:** added await inside create-virtual-symlink ([0b83f78](https://github.com/rxdi/firelink/commit/0b83f78f68ef1da8dd66f2a85a35298383271566))
+- **main:** when firebase crashes it is wrapped inside try catch causing to silend build fails ([9445747](https://github.com/rxdi/firelink/commit/944574740fbcb534540075b3b12d9bd8d982f9b3))
+- **packages:** on windows native fs introduced since the rsync behaviour differs ([d5b0bb4](https://github.com/rxdi/firelink/commit/d5b0bb491c14dc8bd635ccff5ca52bd63eefc72a))
+- **yarn:** version missmatch and wrong generated yarn.lock removed since we have package.lock.json ([7e0fce9](https://github.com/rxdi/firelink/commit/7e0fce993816629210f9abc1bab4961edc58d415))
 
 ### Features
 
-* **actions:** added ci-skip option to publish build if we want to skip ([86430c5](https://github.com/rxdi/firelink/commit/86430c5fc549e6f9c98202eb0a022ffd9f9e14d0))
-* **Binary:** added executable binary so it can be used without nodejs ([7dfe08d](https://github.com/rxdi/firelink/commit/7dfe08d09b0f6fc3604e04d2b1fecce902d36b04))
-* **customOutDir:** added options insideadded option inside fireConfig to specify folder explicitly for out dir .packages ([6315e63](https://github.com/rxdi/firelink/commit/6315e6305c112c18e1b39d4c6a62f0a5062e8d78))
-* **ignore:** added ignore files using pattern and revereted rsync and for windows robocopy is used ([9e311ea](https://github.com/rxdi/firelink/commit/9e311ea6f0d6e8208654654e53161c9a8e8db1f5))
-* **rsync:** removed native rsync process and replaced with nodejs version for cross platform compatability ([096fec7](https://github.com/rxdi/firelink/commit/096fec7fa71e3d463bef0996dfb816eb2d6c0ee8))
-* **Worker:** removed unused if condition and added return type https://github.com/rxdi/firelink/pull/6 ([b93919b](https://github.com/rxdi/firelink/commit/b93919b9d307240276fc8add946d92c773f1cc0c))
-
-
-
+- **actions:** added ci-skip option to publish build if we want to skip ([86430c5](https://github.com/rxdi/firelink/commit/86430c5fc549e6f9c98202eb0a022ffd9f9e14d0))
+- **Binary:** added executable binary so it can be used without nodejs ([7dfe08d](https://github.com/rxdi/firelink/commit/7dfe08d09b0f6fc3604e04d2b1fecce902d36b04))
+- **customOutDir:** added options insideadded option inside fireConfig to specify folder explicitly for out dir .packages ([6315e63](https://github.com/rxdi/firelink/commit/6315e6305c112c18e1b39d4c6a62f0a5062e8d78))
+- **ignore:** added ignore files using pattern and revereted rsync and for windows robocopy is used ([9e311ea](https://github.com/rxdi/firelink/commit/9e311ea6f0d6e8208654654e53161c9a8e8db1f5))
+- **rsync:** removed native rsync process and replaced with nodejs version for cross platform compatability ([096fec7](https://github.com/rxdi/firelink/commit/096fec7fa71e3d463bef0996dfb816eb2d6c0ee8))
+- **Worker:** removed unused if condition and added return type https://github.com/rxdi/firelink/pull/6 ([b93919b](https://github.com/rxdi/firelink/commit/b93919b9d307240276fc8add946d92c773f1cc0c))
diff --git a/src/create-virtual-symlink.ts b/src/create-virtual-symlink.ts
@@ -20,6 +20,7 @@ export async function createVirtualSymlink(
   outFolderName: string,
 ) {
   packageJson.fireConfig = packageJson.fireConfig || ({} as FireLinkConfig);
+  let successStatus = false;
   const runner = packageJson.fireConfig.runner || DEFAULT_RUNNER;
   const excludes = [
     ...(packageJson.fireConfig.excludes || []),
@@ -50,20 +51,25 @@ export async function createVirtualSymlink(
       } catch (e) {}
     }
     process.stdin.resume();
-    process.on('exit', () => exitHandler(originalPackageJson, false));
-    process.on('SIGINT', () => exitHandler(originalPackageJson, false));
-    process.on('SIGUSR1', () => exitHandler(originalPackageJson, false));
-    process.on('SIGUSR2', () => exitHandler(originalPackageJson, false));
+    process.on('exit', () => exitHandler(originalPackageJson, successStatus));
+    process.on('SIGINT', () => exitHandler(originalPackageJson, successStatus));
+    process.on('SIGUSR1', () =>
+      exitHandler(originalPackageJson, successStatus),
+    );
+    process.on('SIGUSR2', () =>
+      exitHandler(originalPackageJson, successStatus),
+    );
     process.on('uncaughtException', () =>
-      exitHandler(originalPackageJson, false),
+      exitHandler(originalPackageJson, successStatus),
     );
     await modifyJson(packageJson, dependencies, outFolder, outFolderName);
   }
   try {
     await runCommand(runner, process.argv);
-    await exitHandler(originalPackageJson, true);
+    successStatus = true;
   } catch (e) {
-    await exitHandler(originalPackageJson, false);
+  } finally {
+    await exitHandler(originalPackageJson, successStatus);
   }
   process.stdin.pause();
 }