Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No unnecessary znode write #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

No unnecessary znode write #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552d724
Added check in write_state to avoid unnecessary updates of nodes znode
gluplu Apr 26, 2014
7b7289d
Removed logger lines
gluplu Apr 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/redis_failover/node_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class NodeManager
MAX_PROMOTION_ATTEMPTS = 3
# Latency threshold for recording node state.
LATENCY_THRESHOLD = 0.5

$previous_value=""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global variable?

# Errors that can happen during the node discovery process.
NODE_DISCOVERY_ERRORS = [
InvalidNodeRoleError,
Expand Down Expand Up @@ -404,7 +404,14 @@ def create_path(path, options = {})
# @note the path will be created if it doesn't exist
def write_state(path, value, options = {})
create_path(path, options.merge(:initial_value => value))
@zk.set(path, value)
if ( path =~ /nodes/ )
if ( $previous_value != value ) then
@zk.set(path, value)
$previous_value = value
end
else
@zk.set(path, value)
end
end

# Handles a manual failover znode update.
Expand Down