-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: change order of array counts in custom error
test: createMultiple function
- Loading branch information
1 parent
53f7b3a
commit 0d0576a
Showing
4 changed files
with
156 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,138 @@ | ||
// SPDX-License-Identifier: UNLICENSED | ||
pragma solidity >=0.8.22; | ||
|
||
import { ISablierV2OpenEnded } from "src/interfaces/ISablierV2OpenEnded.sol"; | ||
import { Errors } from "src/libraries/Errors.sol"; | ||
import { OpenEnded } from "src/types/DataTypes.sol"; | ||
|
||
import { Integration_Test } from "../Integration.t.sol"; | ||
|
||
contract CreateMultiple_Integration_Test is Integration_Test { | ||
address[] internal defaultRecipients; | ||
address[] internal defaultSenders; | ||
uint128[] internal defaultRatesPerSecond; | ||
|
||
function setUp() public override { | ||
Integration_Test.setUp(); | ||
|
||
defaultRecipients.push(users.recipient); | ||
defaultRecipients.push(users.recipient); | ||
defaultSenders.push(users.sender); | ||
defaultSenders.push(users.sender); | ||
defaultRatesPerSecond.push(RATE_PER_SECOND); | ||
defaultRatesPerSecond.push(RATE_PER_SECOND); | ||
} | ||
|
||
function test_RevertWhen_DelegateCall() external { | ||
bytes memory callData = abi.encodeCall( | ||
ISablierV2OpenEnded.createMultiple, (defaultRecipients, defaultSenders, defaultRatesPerSecond, dai) | ||
); | ||
_test_RevertWhen_DelegateCall(callData); | ||
} | ||
|
||
modifier whenArrayCountsNotEqual() { | ||
_; | ||
} | ||
|
||
function test_RevertWhen_RecipientsCountNotEqual() external whenNotDelegateCalled whenArrayCountsNotEqual { | ||
address[] memory recipients = new address[](1); | ||
|
||
vm.expectRevert( | ||
abi.encodeWithSelector( | ||
Errors.SablierV2OpenEnded_CreateMultipleArrayCountsNotEqual.selector, | ||
recipients.length, | ||
defaultSenders.length, | ||
defaultRatesPerSecond.length | ||
) | ||
); | ||
openEnded.createMultiple(recipients, defaultSenders, defaultRatesPerSecond, dai); | ||
} | ||
|
||
function test_RevertWhen_SendersCountNotEqual() external whenNotDelegateCalled whenArrayCountsNotEqual { | ||
address[] memory senders = new address[](1); | ||
|
||
vm.expectRevert( | ||
abi.encodeWithSelector( | ||
Errors.SablierV2OpenEnded_CreateMultipleArrayCountsNotEqual.selector, | ||
defaultRecipients.length, | ||
senders.length, | ||
defaultRatesPerSecond.length | ||
) | ||
); | ||
openEnded.createMultiple(defaultRecipients, senders, defaultRatesPerSecond, dai); | ||
} | ||
|
||
function test_RevertWhen_RatesPerSecondCountNotEqual() external whenNotDelegateCalled whenArrayCountsNotEqual { | ||
uint128[] memory ratesPerSecond = new uint128[](1); | ||
|
||
vm.expectRevert( | ||
abi.encodeWithSelector( | ||
Errors.SablierV2OpenEnded_CreateMultipleArrayCountsNotEqual.selector, | ||
defaultRecipients.length, | ||
defaultSenders.length, | ||
ratesPerSecond.length | ||
) | ||
); | ||
openEnded.createMultiple(defaultRecipients, defaultSenders, ratesPerSecond, dai); | ||
} | ||
|
||
modifier whenArrayCountsEqual() { | ||
_; | ||
} | ||
|
||
function test_CreateMultiple() external whenNotDelegateCalled whenArrayCountsEqual { | ||
uint256 beforeNextStreamId = openEnded.nextStreamId(); | ||
|
||
vm.expectEmit({ emitter: address(openEnded) }); | ||
emit CreateOpenEndedStream({ | ||
streamId: beforeNextStreamId, | ||
sender: users.sender, | ||
recipient: users.recipient, | ||
ratePerSecond: RATE_PER_SECOND, | ||
asset: dai, | ||
lastTimeUpdate: uint40(block.timestamp) | ||
}); | ||
vm.expectEmit({ emitter: address(openEnded) }); | ||
emit CreateOpenEndedStream({ | ||
streamId: beforeNextStreamId + 1, | ||
sender: users.sender, | ||
recipient: users.recipient, | ||
ratePerSecond: RATE_PER_SECOND, | ||
asset: dai, | ||
lastTimeUpdate: uint40(block.timestamp) | ||
}); | ||
|
||
uint256[] memory streamIds = | ||
openEnded.createMultiple(defaultRecipients, defaultSenders, defaultRatesPerSecond, dai); | ||
|
||
uint256 afterNextStreamId = openEnded.nextStreamId(); | ||
|
||
assertEq(streamIds[0], beforeNextStreamId, "streamIds[0] != beforeNextStreamId"); | ||
assertEq(streamIds[1], beforeNextStreamId + 1, "streamIds[1] != beforeNextStreamId + 1"); | ||
|
||
assertEq(streamIds.length, defaultRecipients.length, "streamIds.length != defaultRecipients.length"); | ||
assertEq( | ||
beforeNextStreamId + defaultRecipients.length, | ||
afterNextStreamId, | ||
"afterNextStreamId != beforeNextStreamId + defaultRecipients.length" | ||
); | ||
|
||
OpenEnded.Stream memory expectedStream = OpenEnded.Stream({ | ||
ratePerSecond: RATE_PER_SECOND, | ||
asset: dai, | ||
assetDecimals: 18, | ||
balance: 0, | ||
lastTimeUpdate: uint40(block.timestamp), | ||
isCanceled: false, | ||
isStream: true, | ||
recipient: users.recipient, | ||
sender: users.sender | ||
}); | ||
|
||
OpenEnded.Stream memory actualStream = openEnded.getStream(streamIds[0]); | ||
assertEq(actualStream, expectedStream); | ||
|
||
actualStream = openEnded.getStream(streamIds[1]); | ||
assertEq(actualStream, expectedStream); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
createMultiple.t.sol | ||
βββ when delegate called | ||
β βββ it should revert | ||
βββ when not delegate called | ||
βββ when arrays counts are not equal | ||
β βββ when the recipients array is not equal | ||
β β βββ it should revert | ||
β βββ when the senders array is not equal | ||
β β βββ it should revert | ||
β βββ when the rates per second array is not equal | ||
β βββ it should revert | ||
βββ when arrays counts are equal | ||
βββ it should create multiple streams | ||
βββ it should bump the next stream id multiple times | ||
βββ it should emit multiple {CreateOpenEndedStream} events |