Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add script for deterministic deployment, remove ffi, support stdJson, fix comment #48

Merged
merged 5 commits into from
Apr 22, 2024
Merged

add script for deterministic deployment, remove ffi, support stdJson, fix comment #48

merged 5 commits into from
Apr 22, 2024

Conversation

smol-ninja
Copy link
Member

No description provided.

@smol-ninja smol-ninja mentioned this pull request Apr 20, 2024
Merged
andreivladbrg
andreivladbrg approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@andreivladbrg andreivladbrg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, I agree with the proposed changes; the only issue is that we need to fix the CI

@andreivladbrg
Copy link
Member

find out why it was failing, StdJson file imported needed to be capitalized

@andreivladbrg andreivladbrg merged commit a442b18 into refactor/withdraw-public Apr 22, 2024
5 checks passed
@smol-ninja smol-ninja deleted the refactor/withraw-public-request-changes branch April 22, 2024 15:37
@smol-ninja
Copy link
Member Author

find out why it was failing, StdJson file imported needed to be capitalized

Oh. Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreivladbrg andreivladbrg andreivladbrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smol-ninja @andreivladbrg