Refactoring open ended #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
andreivladbrg
approved these changes
Apr 29, 2024
andreivladbrg
force-pushed
the
open-ended-review
branch
from
c79a993 to
614c84f
Compare
andreivladbrg
added a commit
that referenced
this pull request
May 10, 2024
* feat: add withdrawMultiple function feat: add cancelMultiple functions * chore: capitalize ID in comments * test: rename function to expectRevertNull test: rename function to expectRevertCanceled * test: cancelMultiple function test: add user eve and use for the malicious third party tests * test: add defaultStreamIds array in Integration_Test * test: withdrawMultiple function test: set the block.timestamp to May 1 2024 * feat: implement createMultiple function * feat: implement createAndDepositMultiple function refactor: use specific amount names instead of a generic one * docs: improve readability for streamId requirements test: say "given" for balance zero tests * refactor: change order of array counts in custom error test: createMultiple function * test: createAndDepositMultiple function * Refactoring open ended (#52) * perf: optimize modifiers * refactor: rename streamDebt to streamDebtOf * fix: add override * style: solhint-disable no-console * chore: use return variable in streamDebtOf * test: update streamDebt files --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com> * test: refactor streamDebtOf * test: remove unneeded console log * refactor: say "amount" in function paramaters instead of explicit names * test: correct the contract name test: remove unneeded delegate call test * perf: optimize createAndDepositMultiple * test: remove unneeded delegatecall test in cancelMultiple * test: refactoring relates changes * test: remove unneeded tree branches * test: add modifiers in test_CancelMultiple --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will add to it.
Changelog:
notNullfromnotCanceledto improve readability. This should not have any gas impact.overridemodifier wherever it was missing.notCanceledmodifier becauseisCanceled, being a public function, would consume more gas when called._isCallerStreamSenderfunction as it is nowhere used exceptonlySendermodifier.streamDebttostreamDebtOfbecause rest of the getters are suffixed with "Of".@andreivladbrg would love to have your take on these changes. Ofc these are not final until you agree too.