Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename function to withdrawAtMultiple #76

Merged
merged 1 commit into from
May 11, 2024
Merged

refactor: rename function to withdrawAtMultiple #76

merged 1 commit into from
May 11, 2024

Conversation

andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented May 11, 2024 •
edited
Loading

In the PR #75 we should have also rename withdrawMultiple to withdrawAtMultiple, but we've missed this.

I chose the current version (withdrawAtMultiple) over than withdrawMultipleAt because we will also have withdrawMaxMultiple.

@andreivladbrg andreivladbrg requested a review from smol-ninja May 11, 2024 15:27
@smol-ninja
Copy link
Member

smol-ninja commented May 11, 2024 •
edited
Loading

How about just keeping it withdrawMultiple? Wouldn't withdrawAtMultiple or withdrawMultipleAt be more confusing? I am fine with withdrawMultiple as it sounds more intuitive than having At in it. Does that change your mind? :))

@andreivladbrg
Copy link
Member Author

Why did we change in the first place the withdraw function to withdrawAt?

smol-ninja
smol-ninja approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm good q. It was because of time parameter in withdraw. After second look at the changes, withdrawAtMultiple looks good to me since times is still an input parameter in withdrawAtMultiple.

@andreivladbrg andreivladbrg merged commit 4405fdf into main May 11, 2024
6 checks passed
@andreivladbrg andreivladbrg deleted the refactor/withdrawMultipleAt branch May 11, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smol-ninja smol-ninja smol-ninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreivladbrg @smol-ninja