Refine base tests

[smol-ninja]

Changelogs

• Closes Refine base tests #96
• Replace StdUtils with PRBMathUtils
• Replace StdAssertions with PRBMathAssertions
• Constants and Types contracts. Constants is inherited by Base.
• Add constructor test
• Alphabetical order in Modifers.sol

[andreivladbrg]

Why do we need both Constants & Defaults contracts? The variables in Defaults are just duplicated

We can have only Constants, wdyt? @smol-ninja

[smol-ninja]

Why do we need both Constants & Defaults contracts? The variables in Defaults are just duplicated

The idea was to have one contract for constants and one for default values. The values are not duplicated. Constants has constants while Defaults has default values (inspired from the lockup repo).

We can have only Constants, wdyt

But since there are not many constants, we can merge them as well. But should we not call it Defaults?

[andreivladbrg]

The values are not duplicated. Constants has constants while Defaults has default values

you are correct, i was wrong

But since there are not many constants, we can merge them as well. But should we not call it Defaults?

Yes, we could merge them, but I would prefer to call Constants because in Lockup contracts we define and use the Defaults contract like this (it would not be the same):

// deploy contract
Defaults internal defaults = new Defaults();
// call constant
defaults.MY_CONSTANT();

One disadvantage in having a separate contracts is that it makes debugging messier because you will have a lot of function calls in defaults.

[smol-ninja]

One disadvantage in having a separate contracts is that it makes debugging messier

I agree thats why I made Base contract inherits Defaults so that we don't have to use defaults. anymore. I am fine calling it Constants too.

[andreivladbrg]

@smol-ninja I have squashed and rebased from, and merged Constants & Defaults, lmk if it looks good

[smol-ninja]

LGTM. Thanks for review. Merging now.