feat: refactor batch to revert and return values #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: return results in batch function test: comprehensive testing for batch with Lockup test: move allowToHook call to Integration
This comment was marked as resolved.
This comment was marked as resolved.
|
Pushed a new commit. Now, I think, we have the most comprehensive tests for |
test: refactor BatchMock test: refactor branches in batch tests test: rename initialize function
PaulRBerg
approved these changes
Dec 23, 2024
smol-ninja
commented
Dec 23, 2024
smol-ninja
commented
Dec 23, 2024
tests/integration/concrete/lockup-base/renounce-multiple/renounceMultiple.t.sol
Show resolved
Hide resolved
|
I won't make any edits here, feel free to push a new commit to address the feedback above. |
Co-authored-by: andreivladbrg <andreivladbrg@gmail.com>
|
I have included all the suggestions. Let me know if it looks good now. |
|
You have the honor to squash & merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Regarding tests, because the
batchfunction now returns values, I have taken a different approach to test it with Lockup functions. Please let me know if I have missed anything.