chore: Download latest bundle analysis artifact from base branch #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://fix_bundle_analysis--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
force-pushed
the
fix-bundle-analysis
branch
2 times, most recently
from
2e7e134 to
514d651
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success1288 tests passing in 178 suites. Report generated by 🧪jest coverage report action from 16b9bde |
usame-algan
force-pushed
the
fix-bundle-analysis
branch
6 times, most recently
from
af7d339 to
9f75fe7
Compare
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
usame-algan
force-pushed
the
fix-bundle-analysis
branch
from
9f75fe7 to
bf119b6
Compare
usame-algan
force-pushed
the
fix-bundle-analysis
branch
from
bf119b6 to
16b9bde
Compare
katspaugh
approved these changes
Dec 11, 2023
usame-algan
commented
Dec 11, 2023
| set +x | ||
| curl -H "Accept: application/vnd.github+json" -H "Authorization: token $GH_TOKEN" -L -o "${DESTINATION}.zip" "$DOWNLOAD_URL" | ||
| set -x | ||
| unzip "${DESTINATION}.zip" -d "${DESTINATION}" && mkdir -p "${DESTINATION}/bundle" && mv "${DESTINATION}/__bundle_analysis.json" "${DESTINATION}/bundle/" |
There was a problem hiding this comment.
We need to unzip the contents of ${DESTINATION}.zip into the directory ${DESTINATION}/bundle. I tried using wildcards but without success so I hard-code the filename here.
Agreed, I've left a message in a related issue on hashicorp/nextjs-bundle-analysis#66 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Follow up for #2803
The download-artifact action we use downloads artifacts in chronological order so it always compares with the oldest dev bundle instead of the newest. There is an open issue on the board but no fix so far (see discussion). We switch to a custom bash script that is also linked in the discussion to download and unzip the bundle from dev.
Screenshots
Checklist