Cumulative Fixes and Improvements #2255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 345 345
Lines 20745 20745
Branches 483 483
=======================================
Hits 19723 19723
Misses 539 539
Partials 483 483 |
allentiak
changed the title
* `generate-error-payload` (and not just `error`) is what the function actually does * Whereas the names `e` and `ex` are quite similar, they can still generate some confusion.
allentiak
force-pushed
the
minor-refactoring
branch
from
23f56ac to
78871ca
Compare
allentiak
changed the title
allentiak
force-pushed
the
minor-refactoring
branch
from
08bd83e to
760d19c
Compare
The body should contain a JSON payload with the OperationOutcome, not the OperationOutcome itself. We use JSON because it is our default.
allentiak
force-pushed
the
minor-refactoring
branch
from
760d19c to
61c4925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.