Skip to content

Commit

Permalink
Merge pull request #256 from SamSchott/develop
Browse files Browse the repository at this point in the history
Release v1.3.1
  • Loading branch information
SamSchott authored Dec 5, 2020
2 parents e7bbf17 + 364d682 commit b4d99eb
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 1.3.0
current_version = 1.3.1
commit = True
tag = False
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(\.(?P<release>[a-z]+)(?P<build>\d+))?
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## v1.3.1

#### Fixes:

* Fixes an incorrect entry point for the Qt GUI.

## v1.3.0

This release features an overhaul of the command line interface: commands are grouped
Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# -- Project information ---------------------------------------------------------------

author = "Sam Schott"
version = "1.3.0"
version = "1.3.1"
release = version
project = "Maestral"
title = "Maestral API Documentation"
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
]

gui_requires = [
"maestral-qt>=1.3.0;sys_platform=='linux'",
"maestral-qt>=1.3.1;sys_platform=='linux'",
"maestral-cocoa>=1.3.0;sys_platform=='darwin'",
]

Expand All @@ -56,7 +56,7 @@
name="maestral",
author="Sam Schott",
author_email="ss2151@cam.ac.uk",
version="1.3.0",
version="1.3.1",
url="https://github.com/SamSchott/maestral",
description="Open-source Dropbox client for macOS and Linux.",
license="MIT",
Expand Down
2 changes: 1 addition & 1 deletion src/maestral/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import warnings

__version__ = "1.3.0"
__version__ = "1.3.1"
__author__ = "Sam Schott"
__url__ = "https://github.com/SamSchott/maestral"

Expand Down
4 changes: 2 additions & 2 deletions src/maestral/daemon.py
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ def start_maestral_daemon_process(
Starts the Maestral daemon in a new process by calling :func:`start_maestral_daemon`.
Startup is race free: there will never be two daemons running for the same config.
This function requires that :obj:`sys.executable` points to a Python executable and
therefore may not work "frozen" apps.
therefore may not work for "frozen" apps.
:param config_name: The name of the Maestral configuration to use.
:param log_to_stdout: If ``True``, write logs to stdout.
Expand Down Expand Up @@ -597,7 +597,7 @@ def stop_maestral_daemon_process(
:param config_name: The name of the Maestral configuration to use.
:param timeout: Number of sec to wait for daemon to shut down before killing it.
:returns: :attr:`Stop.Ok` if successful, :attr:`Stop.Killed` if killed,
:attr:`Stop.NotRunning` if the daemon was not running and `:attr:`Stop.Failed`
:attr:`Stop.NotRunning` if the daemon was not running and :attr:`Stop.Failed`
if killing the process failed because we could not retrieve its PID.
"""

Expand Down
14 changes: 10 additions & 4 deletions src/maestral/logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@
from .utils import sanitize_string


__all__ = [
"EncodingSafeLogRecord",
"CachedHandler",
"SdNotificationHandler",
"safe_journal_sender",
]


if journal:

def safe_journal_sender(MESSAGE: str, **kwargs) -> None:
Expand All @@ -46,7 +54,7 @@ class EncodingSafeLogRecord(logging.LogRecord):
This is useful when log messages may contain file paths generates by OS APIs. In
Python, such path strings may contain surrogate escapes and will therefore raise
:class:`UnicodeEncodingError`s under many circumstances (printing to stdout, etc).
a :class:`UnicodeEncodeError` under many circumstances (printing to stdout, etc).
"""

def getMessage(self) -> str:
Expand Down Expand Up @@ -101,7 +109,7 @@ def wait_for_emit(self, timeout: Optional[float]) -> bool:
Blocks until a new record is emitted.
:param timeout: Maximum time to block before returning.
:returns: ``True``if there was a status change, ``False`` in case of a timeout.
:returns: ``True`` if there was a status change, ``False`` in case of a timeout.
"""
done, not_done = wait([self._emit_future], timeout=timeout)
self._emit_future = Future() # reset future
Expand Down Expand Up @@ -135,8 +143,6 @@ class SdNotificationHandler(logging.Handler):
This is useful when used from a systemd service and will do nothing when no
NOTIFY_SOCKET is provided.
:param level: Initial log level. Defaults to NOTSET.
"""

notifier = sdnotify.SystemdNotifier()
Expand Down

0 comments on commit b4d99eb

Please sign in to comment.