Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions on the use of a fork of notify #312

Open
baldurmen opened this issue Nov 25, 2024 · 1 comment · May be fixed by #322
Open

Questions on the use of a fork of notify #312

baldurmen opened this issue Nov 25, 2024 · 1 comment · May be fixed by #322
Labels

Comments

@baldurmen
Copy link

Description

Hello!

I maintain this library in Debian.

Since 6e3c2c8, watchfiles has been using a fork of the notify library.

I though this might have been a temporary fix, but now that version 1.0.0 has been released with it, I wanted to ask what are you plans with regards to this situation.

On the Debian side, using forks like that for a particular project makes it pretty hard to keep packaging this library. Depending on a git branch instead of a proper release makes it even harder in fact :(

Cheers,

Example Code

No response

Watchfiles Output

No response

Operating System & Architecture

N/A

Environment

No response

Python & Watchfiles Version

N/A

Rust & Cargo Version

No response

@baldurmen baldurmen added the bug label Nov 25, 2024
@musicinmybrain
Copy link

I’m chiming in because I was looking at updating the python-watchfiles package in Fedora.

We can handle git dependencies like this – we have a policy for them – but it’s something we want to avoid as much as possible, and per our general policy for bundling, we need to specifically ask about a path toward using a system copy of that library. (This comment is intended to satisfy that requirement.)

Is there a path to getting notify-rs/notify@0f87ab1 upstream so you don’t have to fork notify forever?

musicinmybrain added a commit to musicinmybrain/watchfiles that referenced this issue Jan 2, 2025
@musicinmybrain musicinmybrain linked a pull request Jan 2, 2025 that will close this issue
musicinmybrain added a commit to musicinmybrain/watchfiles that referenced this issue Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants