Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use notify 7.0.0 instead of a fork of 6.1.1 #322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

musicinmybrain
Copy link

As @decathorpe noticed, notify-rs/notify@146b1bd appears to be the same as notify-rs/notify@0f87ab1 in the notify fork.

Therefore, it should be possible to use the released version of notify 7.0.0.

I tried this and got one test failure,

=================================================================================================== FAILURES ===================================================================================================
_________________________________________________________________________________________ test_awatch_interrupt_raise __________________________________________________________________________________________

self = <tests.test_watch.MockRustNotifyRaise object at 0x7ff6cadfbb60>, args = (1600, 50, 5000, <threading.Event at 0x7ff6ca55c9b0: set>)

    def watch(self, *args):
        if self.i == 1:
>           raise KeyboardInterrupt('test error')
E           KeyboardInterrupt: test error

tests/test_watch.py:204: KeyboardInterrupt
[…]

but this already happens for me on the current main, so this isn’t a regression.

This PR would resolve #312.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questions on the use of a fork of notify
1 participant