Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: Update PyO3 to 0.22.1 #286

Closed
wants to merge 1 commit into from
Closed

Conversation

EwoutH
Copy link

@EwoutH EwoutH commented Jul 8, 2024

Updates the PyO3 dependency to 0.22.1 in Cargo.toml. This should help with Python 3.13 compatibility.

Updates the PyO3 dependency to 0.22.1 in Cargo.toml.

This should help with Python 3.13 compatibility.
@EwoutH
Copy link
Author

EwoutH commented Jul 8, 2024

I have no idea about the CI failures. There is a migration guide for PyO3, it might be helpful: https://pyo3.rs/v0.22.1/migration

@edgarrmondragon
Copy link

edgarrmondragon commented Jul 8, 2024

@EwoutH you might wanna take a look at crate-py/rpds#79 for a similar migration to PyO3 0.22.1

I see you commented there 😅

@EwoutH
Copy link
Author

EwoutH commented Jul 8, 2024

Thanks for the reference! Unfortunately, I can't fix this myself, I'm not a Rust dev. Just following the rabbit hole of upstream dependencies.

I hope anyone would be able to work on this!

@samuelcolvin
Copy link
Owner

you'll need to update Cargo.lock too.

I would say these are real compatibility issues related to the new PyO3 API that will need to be fixed.

@EwoutH
Copy link
Author

EwoutH commented Jul 8, 2024

Thanks, I'm going to close this PR, since I'm not going to be able to fix it. We can use #276 to track this issue further.

@EwoutH EwoutH closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants