Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow modify poll_delay_ms argument using an environment variable #303

Merged

Conversation

joelpelaez
Copy link
Contributor

related #302

Add a new environment variable named WATCHFILES_POLL_DELAY_MS can allow change poll_delay_ms argument value from functions watch and awatch.

It helps when other libraries uses watchfiles and poll delay value can't be changed directly using thrid party library interfaces.

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

watchfiles/main.py Outdated Show resolved Hide resolved
watchfiles/main.py Outdated Show resolved Hide resolved
watchfiles/main.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (a81a7c6) to head (67fe6ed).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   99.51%   99.06%   -0.45%     
==========================================
  Files           6        6              
  Lines         416      430      +14     
  Branches       77       79       +2     
==========================================
+ Hits          414      426      +12     
- Misses          1        2       +1     
- Partials        1        2       +1     
Files with missing lines Coverage Δ
watchfiles/main.py 96.80% <100.00%> (-1.40%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3c2c8...67fe6ed. Read the comment docs.

---- 🚨 Try these New Features:

@samuelcolvin samuelcolvin merged commit e14de63 into samuelcolvin:main Nov 24, 2024
48 checks passed
@samuelcolvin
Copy link
Owner

thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants