use new go-bits/easypg test DB API #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
majewsky
force-pushed
the
new-testdb-infrastructure
branch
6 times, most recently
from
f2cb723 to
ccdb1dc
Compare
majewsky
force-pushed
the
new-testdb-infrastructure
branch
from
ccdb1dc to
026eb00
Compare
SuperSandro2000
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a small reworking of the
db.Init()method to split the DB connection and ORM initialization phase.Also, I noticed that the sqlstats collector is not being initialized with the right DB name. (It only worked if the default name was used.)