add unit tests for environment metadata

sapcxtools · Jul 15, 2024 · 4c0b87e · 4c0b87e
1 parent 051413e
commit 4c0b87e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/...envconfig/src/tools/sapcx/commerce/config/controller/FrontendConfigurationController.java b/...envconfig/src/tools/sapcx/commerce/config/controller/FrontendConfigurationController.java
@@ -14,7 +14,6 @@
 
 @RestController
 @RequestMapping(value = "/{baseSiteId}/configuration")
-// @CacheControl(directive = CacheControlDirective.PUBLIC, maxAge = 360)
 public class FrontendConfigurationController {
 	@Resource
 	private FrontendConfigurationService frontendConfigurationService;

diff --git a/...tools/sapcx/commerce/config/frontend/EnvironmentSpecificFrontendConfigurationService.java b/...tools/sapcx/commerce/config/frontend/EnvironmentSpecificFrontendConfigurationService.java
@@ -10,8 +10,8 @@
 import pl.jalokim.propertiestojson.util.PropertiesToJsonConverterBuilder;
 
 public class EnvironmentSpecificFrontendConfigurationService implements FrontendConfigurationService {
-	private static final String ENVIRONMENT_ID_CONFIGURATION_KEY = "sapcxenvconfig.environment.id";
-	private static final String ENVIRONMENT_NAME_CONFIGURATION_KEY = "sapcxenvconfig.environment.name";
+	static final String ENVIRONMENT_ID_CONFIGURATION_KEY = "sapcxenvconfig.environment.id";
+	static final String ENVIRONMENT_NAME_CONFIGURATION_KEY = "sapcxenvconfig.environment.name";
 	static final String FRONTEND_CONFIGURATION_PREFIX = "sapcxenvconfig.frontend";
 
 	private ConfigurationService configurationService;

diff --git a/.../sapcx/commerce/config/frontend/EnvironmentSpecificFrontendConfigurationServiceTests.java b/.../sapcx/commerce/config/frontend/EnvironmentSpecificFrontendConfigurationServiceTests.java
@@ -1,6 +1,8 @@
 package tools.sapcx.commerce.config.frontend;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static tools.sapcx.commerce.config.frontend.EnvironmentSpecificFrontendConfigurationService.ENVIRONMENT_ID_CONFIGURATION_KEY;
+import static tools.sapcx.commerce.config.frontend.EnvironmentSpecificFrontendConfigurationService.ENVIRONMENT_NAME_CONFIGURATION_KEY;
 import static tools.sapcx.commerce.config.frontend.EnvironmentSpecificFrontendConfigurationService.FRONTEND_CONFIGURATION_PREFIX;
 
 import java.util.Map;
@@ -96,6 +98,15 @@ public void withPropertyTreeSet_shouldCacheResult() {
 		assertThat(end1 - start1).isGreaterThanOrEqualTo(end2 - start2);
 	}
 
+	@Test
+	public void withEnvironmentConfiguration_shouldReturnEnvironmentMetadata() {
+		setupService(Map.of(
+				ENVIRONMENT_ID_CONFIGURATION_KEY, "ID",
+				ENVIRONMENT_NAME_CONFIGURATION_KEY, "NAME"));
+		assertThat(service.getEnvironmentId()).isEqualTo("ID");
+		assertThat(service.getEnvironmentName()).isEqualTo("NAME");
+	}
+
 	private void setupService(Map<String, String> properties) {
 		configurationService = new ConfigurationServiceFake();
 		properties.forEach(configurationService::setProperty);