Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yen (JPY) and won (KRW) for European languages #604

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

bryananderson
Copy link
Contributor

@bryananderson bryananderson commented Dec 15, 2024

Changes proposed in this pull request:

  • Add Japanese yen (JPY) and Korean won (KRW) currency support for European languages (those which inherit from Num2Words_EU)
  • Add a test in test_en.py

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Run tests

@coveralls
Copy link

coveralls commented Dec 17, 2024

Coverage Status

coverage: 98.07%. remained the same
when pulling b1a9419 on bryananderson:lang-eu-yen
into 1e6e57f on savoirfairelinux:master.

@bryananderson
Copy link
Contributor Author

It looks like this and my other two PRs are failing to build because of an issue in the CI (python3.7 not found), does 3.7 need to be removed from the CI?

@mrodriguezg1991 mrodriguezg1991 merged commit beca211 into savoirfairelinux:master Jan 6, 2025
14 checks passed
@bryananderson bryananderson deleted the lang-eu-yen branch January 8, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants