Merge pull request #77 from scheduleonce/pythons/ONCEHUB-82384

Pythons/oncehub 82384
scheduleonce · Sep 4, 2024 · 4f20686 · 4f20686
2 parents ed3c6c9 + c4b8989
commit 4f20686
Show file tree

Hide file tree

Showing 11 changed files with 8,829 additions and 16,464 deletions.
diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
@@ -13,7 +13,7 @@ jobs:
       # setup .npmrc file to publish to npm
       - uses: actions/setup-node@v3
         with:
-          node-version: "18.x"
+          node-version: "20.x"
           registry-url: "https://registry.npmjs.org"
       - name: "Publish"
         working-directory: ./builder

diff --git a/builder/package-lock.json b/builder/package-lock.json
diff --git a/builder/package.json b/builder/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@oncehub/ng-strictify",
-  "version": "2.0.5",
+  "version": "2.0.4",
   "description": "Incrementally update your Angular project to use the Typescript strict flag.",
   "main": "dist/src/index.js",
   "builders": "builders.json",
@@ -14,11 +14,11 @@
   "author": "Prakash-Verma <prakash.verma@oncehub.com>",
   "license": "MIT",
   "devDependencies": {
-    "@types/node": "^14.14.26",
-    "typescript": "4.1.5"
+    "@types/node": "^22.5.1",
+    "typescript": "^5.5.4"
   },
   "dependencies": {
-    "@angular-devkit/architect": "^0.901.15"
+    "@angular-devkit/architect": "^0.1802.1"
   },
   "repository": {
     "type": "git",

diff --git a/builder/strictify/helper.ts b/builder/strictify/helper.ts
@@ -18,7 +18,7 @@ export function executeBuildCommandInChild(
     `${options.buildScript}`,
     `--`,
     `--ts-config=${tsConfigPath}`,
-  ]);
+  ], { stdio: ['pipe', 'pipe', 'pipe'], shell: true });
   return buildProcess;
 }
 

diff --git a/test-app/.browserslistrc b/test-app/.browserslistrc
diff --git a/test-app/angular.json b/test-app/angular.json
@@ -18,22 +18,24 @@
       "prefix": "app",
       "architect": {
         "build": {
-          "builder": "@angular-devkit/build-angular:browser",
+          "builder": "@angular/build:application",
           "options": {
-            "outputPath": "dist/test-app",
+            "outputPath": {
+              "base": "dist/test-app"
+            },
             "index": "src/index.html",
-            "main": "src/main.ts",
-            "polyfills": "src/polyfills.ts",
+            "polyfills": [
+              "src/polyfills.ts"
+            ],
             "tsConfig": "tsconfig.app.json",
             "assets": ["src/favicon.ico", "src/assets"],
             "styles": ["src/styles.scss"],
             "scripts": [],
-            "vendorChunk": true,
             "extractLicenses": false,
-            "buildOptimizer": false,
             "sourceMap": true,
             "optimization": false,
-            "namedChunks": true
+            "namedChunks": true,
+            "browser": "src/main.ts"
           },
           "configurations": {
             "production": {
@@ -48,8 +50,6 @@
               "sourceMap": false,
               "namedChunks": false,
               "extractLicenses": true,
-              "vendorChunk": false,
-              "buildOptimizer": true,
               "budgets": [
                 {
                   "type": "initial",
@@ -67,20 +67,20 @@
           "defaultConfiguration": ""
         },
         "serve": {
-          "builder": "@angular-devkit/build-angular:dev-server",
+          "builder": "@angular/build:dev-server",
           "options": {
-            "browserTarget": "test-app:build"
+            "buildTarget": "test-app:build"
           },
           "configurations": {
             "production": {
-              "browserTarget": "test-app:build:production"
+              "buildTarget": "test-app:build:production"
             }
           }
         },
         "extract-i18n": {
-          "builder": "@angular-devkit/build-angular:extract-i18n",
+          "builder": "@angular/build:extract-i18n",
           "options": {
-            "browserTarget": "test-app:build"
+            "buildTarget": "test-app:build"
           }
         },
         "strictify": {
@@ -92,5 +92,8 @@
         }
       }
     }
+  },
+  "cli": {
+    "analytics": false
   }
 }