Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Button margin top removed #879

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

skbhagat0502
Copy link
Contributor

Issue Number #878

The save button looks proper now. Here what it was looking like before with more margin top.

image

Now it looks like this

image

@skbhagat0502
Copy link
Contributor Author

@shivareddy6 , I have made the pull request. Please have a look.

@shivareddy6
Copy link
Collaborator

@skbhagat0502, did you check the spacing in various screen sizes?

@skbhagat0502
Copy link
Contributor Author

@shivareddy6 , yes I have checked it for all screen sizes and it is looking proper.

@skbhagat0502
Copy link
Contributor Author

@shivareddy6 , is there any issue with this? Tell me I will make a new PR with correction.

@shivareddy6
Copy link
Collaborator

@shivareddy6 , is there any issue with this? Tell me I will make a new PR with correction.

@skbhagat0502, I was waiting for the checks to run. I've added my review and once we get 2 or more reviews, we can merge.

@skbhagat0502
Copy link
Contributor Author

ok @shivareddy6

@shivareddy6 shivareddy6 merged commit cbddd23 into scorelab:master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants