Fix minor issues in Python build scripts #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that Python will not go over 3.10 and end up unexpectedly breaking the build.
At the very least, this should provide a clear indication of which version of a package we are using.
This commit affects both properties.py and version.py. In essence, the command executions were replaced in favor of the `GitPython` library interface. This results in cleaner and simpler code, that will no doubt be easier to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a migration from native
gittoGitPython, which in turn requiredpippackage management through arequirements.txtfile. This file can be used to configure the Python dependencies across scripts.