Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sml/svm #362

Merged
merged 16 commits into from
Oct 27, 2023
Merged

add sml/svm #362

merged 16 commits into from
Oct 27, 2023

Conversation

lwxxxxxxx
Copy link
Contributor

@lwxxxxxxx lwxxxxxxx commented Oct 5, 2023

按照最新的版本增加了svm

@anakinxc anakinxc requested a review from deadlywing October 8, 2023 07:39
sml/svm/emulations/svm_emul.py Show resolved Hide resolved
sml/svm/smo.py Outdated Show resolved Hide resolved
sml/svm/svm.py Show resolved Hide resolved
sml/svm/tests/svm_test.py Show resolved Hide resolved
sml/svm/smo.py Show resolved Hide resolved
sml/svm/svm.py Outdated Show resolved Hide resolved
sml/svm/svm.py Outdated Show resolved Hide resolved
sml/svm/svm.py Outdated Show resolved Hide resolved
sml/svm/svm.py Show resolved Hide resolved
sml/svm/smo.py Show resolved Hide resolved
@deadlywing
Copy link
Contributor

@lwxxxxxxx sorry, 前端时间有点忙,delay了有点久

整体来看代码没啥大问题,有一些格式上的和一些需要补充的内容~

Thanks

@lwxxxxxxx
Copy link
Contributor Author

@lwxxxxxxx sorry, 前端时间有点忙,delay了有点久

整体来看代码没啥大问题,有一些格式上的和一些需要补充的内容~

Thanks

hello,前面提到的格式上的问题和需要补充的内容都已经解决了,麻烦再看看还有什么需要修改的~Thanks

sml/svm/svm.py Show resolved Hide resolved
sml/svm/svm.py Outdated Show resolved Hide resolved
sml/svm/svm.py Outdated Show resolved Hide resolved
sml/svm/svm.py Outdated Show resolved Hide resolved
sml/svm/svm.py Outdated Show resolved Hide resolved
@lwxxxxxxx
Copy link
Contributor Author

@deadlywing hello,上面提到的四个问题也已经解决~

Copy link
Contributor

@deadlywing deadlywing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadlywing deadlywing merged commit d386d3f into secretflow:main Oct 27, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants