-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[add] GTree based Decision Tree #367
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@ElleryQu 抱歉,,前段时间有点忙,delay了一段时间; 另外,麻烦下次push之前对代码的格式做一些调整:
|
好嘞,感谢 |
您好,上述问题已经修改。
|
python format 仍然有点问题 |
test文件中 +1-1那里还没有修改哈~ |
您好,这里是为了保证jax.equal结果在SPU上是加法共享,如果改成+0会被解释器优化掉。 如果不加+1-1,jax.equal的结果为布尔分享,赋值时会发生错误。review展示了一个最小的错误例子。这种错误会导致在iris_data上分类正确率降低至66%。 |
hi,我自己本地试了一下,并没有发现准确性下降的情况,,能辛苦贴一下具体的运行setting和结果么? |
没有复现出来,但之前确实遇到过这个问题( ̄  ̄|| ) 删除了+1-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request
What problem does this PR solve?
Issue Number: Fixed #212
Possible side effects?
test:
emulation:
Running time in SPU: 77.37s
Accuracy in SKlearn: 0.96
Accuracy in SPU: 0.96
[2023-10-13 18:35:38,091] Shutdown multiprocess cluster...