Add option for blinking cursor

sedwards2009 · May 3, 2024 · 402c09b · 402c09b
1 parent 62c14f1
commit 402c09b
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/main/src/Window.ts b/main/src/Window.ts
@@ -975,6 +975,7 @@ export class Window implements Disposable {
     if (!(oldConfig.terminalFont === newConfig.terminalFont &&
         oldConfig.terminalFontSize === newConfig.terminalFontSize &&
         oldConfig.cursorStyle === newConfig.cursorStyle &&
+        oldConfig.blinkingCursor === newConfig.blinkingCursor &&
         oldConfig.themeTerminal === newConfig.themeTerminal &&
         oldConfig.terminalDisplayLigatures === newConfig.terminalDisplayLigatures &&
         oldConfig.terminalMarginStyle === newConfig.terminalMarginStyle)) {

diff --git a/main/src/emulator/TextTerm.ts b/main/src/emulator/TextTerm.ts
@@ -611,6 +611,7 @@ export class TextEmulator implements TextEmulatorApi {
       this.#send('\x1b[O');
     }
     this.#hasFocus = false;
+    this.#cursorBlinkState = true;
     this.#scheduleCursorRefresh();
   }
 

diff --git a/main/src/settings/AppearancePage.ts b/main/src/settings/AppearancePage.ts
@@ -257,6 +257,15 @@ export class AppearancePage implements SettingsPageType {
                   }),
                 ),
 
+                "",
+                CheckBox({
+                  text: "Blink",
+                  checkState: generalConfig.blinkingCursor,
+                  onStateChanged: (state: number) => {
+                    update((c) => c.blinkingCursor = Boolean(state));
+                  }
+                }),
+
                 "Margin:",
                 shrinkWrap(ComboBox({
                   currentIndex: marginSizes.indexOf(generalConfig.terminalMarginStyle),

diff --git a/main/src/terminal/Terminal.ts b/main/src/terminal/Terminal.ts
@@ -914,6 +914,10 @@ export class Terminal implements Tab, Disposable {
     }
     `, false);
 
+    if (this.#emulator != null) {
+      this.#emulator.setCursorBlink(terminalVisualConfig.cursorBlink);
+    }
+
     this.resizeTerminalArea();
   }
 
@@ -1098,9 +1102,10 @@ export class Terminal implements Tab, Disposable {
     });
 
     emulator.onWriteBufferSize(this.#handleWriteBufferSize.bind(this));
-    // if (this._terminalVisualConfig != null) {
-    //   emulator.setCursorBlink(this._terminalVisualConfig.cursorBlink);
-    // }
+
+    if (this.#terminalVisualConfig != null) {
+      emulator.setCursorBlink(this.#terminalVisualConfig.cursorBlink);
+    }
 
     this.#enforceScrollbackSizeLater = new DebouncedDoLater(() => {
       this.#laterEnforceScrollbackSize();