-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FUNK-1504] actions-webhook-extensible - Make changes to oauth2 refresh token handler #2630
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2630 +/- ##
==========================================
- Coverage 78.97% 78.51% -0.46%
==========================================
Files 1083 1030 -53
Lines 20838 18199 -2639
Branches 4150 3436 -714
==========================================
- Hits 16456 14289 -2167
+ Misses 3233 2767 -466
+ Partials 1149 1143 -6 ☔ View full report in Codecov by Sentry. |
}, | ||
body: new URLSearchParams({ | ||
grant_type: 'refresh_token', | ||
refresh_token: auth.refreshToken ?? oauth.access.refresh_token, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callout - will get rid of this in the next iteration when we introduce dynamic auth options in the authentication types in destination kit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the access path oauth.access.refresh_token
correct? or should it be oauth.refresh_token
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oauth.access.refresh_token
, access
has tokens and ttl
Made changes to to the refreshtoken handler to handle different flows for oauth2.0
Changes limited to action folder
Precursor to removing duplicate oauth object inside dynamicAuthSettings and introducing dynamic auth options into Destination Kit
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.