Refactored clang version check into a python script. (#1471)

* Refactored check-check-clang-format-version to a python script to fix crashes on win32.

* Lint

* Changed exit codes to ValueError exception.

* Split subprocess arguments string.

* Explicitly call python3.

* Changed string split to use default whitespace separators.

.pre-commit-config.yaml

@@ -5,8 +5,8 @@ repos:
     hooks:
       - id: check-clang-format-version
         name: Check clang-format version
-        entry: ./ci/check-clang-format-version.sh
-        language: script
+        entry: python3 ./ci/check-clang-format-version.py
+        language: system
       - id: clang-format
         name: Clang format
         entry: clang-format

ci/check-clang-format-version.py

@@ -0,0 +1,18 @@
+import subprocess
+
+EXPECTED_CLANG_VERSION = "18.1.6"
+
+
+def main():
+    result = subprocess.run(("clang-format", "--version"), capture_output=True)
+    result.check_returncode()
+
+    version_str = result.stdout.decode("utf-8").split()[2].strip()
+    if version_str != EXPECTED_CLANG_VERSION:
+        raise ValueError(
+            f"Error: Found clang-format version {version_str}, but {EXPECTED_CLANG_VERSION} is required."
+        )
+
+
+if __name__ == "__main__":
+    main()