Fix cppcheck postfix operator issues #1251
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1251 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.01%
==========================================
Files 161 161
Lines 20750 20737 -13
Branches 7832 7838 +6
==========================================
- Hits 17103 17091 -12
+ Misses 2979 2977 -2
- Partials 668 669 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Common++/src/TablePrinter.cpp
Outdated
| } | ||
|
|
||
| totalLen++; | ||
| int totalLen = std::accumulate(m_ColumnWidths.begin(), m_ColumnWidths.end(), m_ColumnWidths.size() * 3) + 1; |
|
@egecetin I would suggest not using |
…into fix-postfix
Common++/src/TablePrinter.cpp
Outdated
| } | ||
|
|
||
| totalLen++; | ||
| int totalLen = std::accumulate(m_ColumnWidths.begin(), m_ColumnWidths.end(), m_ColumnWidths.size() * 3) + 1; |
There was a problem hiding this comment.
nit: maybe use auto for totalLen and for the for loop later?
|
A not important note, I noticed there are still some postfix operators not generating warnings. For example you mentioned a for loop in #1251 (comment) which has |
Most of the postfix warnings comes from old iterator based for loops so replaced them with
autoto help #977