Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move doxygen to GitHub Actions #1458

Merged
merged 29 commits into from
Jun 23, 2024
Merged

Move doxygen to GitHub Actions #1458

merged 29 commits into from
Jun 23, 2024

Conversation

seladb
Copy link
Owner

@seladb seladb commented Jun 23, 2024

  • Move doxygen to GitHub Actions and remove it from Cirrus CI
  • Temporary comment-out all Cirrus CI tasks so we can merge PRs

@seladb seladb changed the base branch from master to dev June 23, 2024 02:31
seladb added 5 commits June 22, 2024 23:08
- Remove build documentation from Cirrus CI
- Temporary comment out the rest of Cirrus CI tasks
@seladb seladb marked this pull request as ready for review June 23, 2024 06:58
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (e3128c6) to head (707479d).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1458      +/-   ##
==========================================
- Coverage   82.66%   82.65%   -0.02%     
==========================================
  Files         171      171              
  Lines       22585    22585              
  Branches     8559     8559              
==========================================
- Hits        18671    18667       -4     
- Misses       3116     3137      +21     
+ Partials      798      781      -17     
Flag Coverage Δ
alpine317 72.72% <ø> (ø)
fedora37 72.73% <ø> (+0.04%) ⬆️
macos-12 61.50% <ø> (ø)
macos-13 60.55% <ø> (ø)
macos-14 60.55% <ø> (-0.01%) ⬇️
macos-ventura ?
mingw32 70.69% <ø> (ø)
mingw64 70.67% <ø> (-0.05%) ⬇️
npcap 83.91% <ø> (ø)
rhel93 72.74% <ø> (ø)
ubuntu1804 75.21% <ø> (-0.05%) ⬇️
ubuntu2004 73.69% <ø> (-0.01%) ⬇️
ubuntu2204 72.55% <ø> (+0.04%) ⬆️
ubuntu2204-icpx 59.03% <ø> (-0.04%) ⬇️
unittest 82.65% <ø> (-0.02%) ⬇️
windows-2019 83.93% <ø> (ø)
windows-2022 83.93% <ø> (ø)
winpcap 83.90% <ø> (ø)
xdp 60.18% <ø> (ø)
zstd ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clementperon
Copy link
Collaborator

@seladb should It be a different workflow?

@seladb
Copy link
Owner Author

seladb commented Jun 23, 2024

@seladb should It be a different workflow?

I'm not sure it's necessary, because a major part is to test doxygen which is part of build_and_test

@tigercosmos
Copy link
Collaborator

@seladb should It be a different workflow?

I'm not sure it's necessary, because a major part is to test doxygen which is part of build_and_test

@seladb I think it is worth doing that, since we can easily track the CI category at the panel:
image

@clementperon
Copy link
Collaborator

@seladb should It be a different workflow?

I'm not sure it's necessary, because a major part is to test doxygen which is part of build_and_test

@seladb I think it is worth doing that, since we can easily track the CI category at the panel:

@seladb @tigercosmos to me the other reason is that the triggering mode could differs from the build_package but maybe i'm wrong, So it don't have a strong opinion.

@tigercosmos tigercosmos merged commit 62fc719 into dev Jun 23, 2024
36 checks passed
@tigercosmos tigercosmos deleted the move-doxygen-to-gh-actions branch June 23, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants