-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Zstd tests from CirrusCI to GitHub Actions #1459
Conversation
seladb
commented
Jun 23, 2024
•
edited
Loading
edited
- Move Zstd tests from CirrusCI to GitHub Actions
- Comment out the rest of Cirrus CI jobs so we can merge the PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1459 +/- ##
=======================================
Coverage 82.65% 82.65%
=======================================
Files 171 171
Lines 22585 22585
Branches 8559 8559
=======================================
Hits 18668 18668
+ Misses 3136 3101 -35
- Partials 781 816 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# excludes ZSTD on Arm64 | ||
- arch: arm64 | ||
include: | ||
- os-version: macos-12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no macos-14? maybe we should just maintain 13 and 14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS 14 is M1 only: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
macOS 12 and 13 are also x86_64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seladb I see, then don't we test zstd on macos 14 arm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to test Zstd on all archs.
I tried on arm64 and it didn't work, probably because the Zstd version installed on this machine isn't compiled with arm64, so x86_64 is currently the only option