Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Zstd tests from CirrusCI to GitHub Actions #1459

Merged
merged 4 commits into from
Jun 23, 2024

Conversation

seladb
Copy link
Owner

@seladb seladb commented Jun 23, 2024

  • Move Zstd tests from CirrusCI to GitHub Actions
  • Comment out the rest of Cirrus CI jobs so we can merge the PR

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (62fc719) to head (c088526).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1459   +/-   ##
=======================================
  Coverage   82.65%   82.65%           
=======================================
  Files         171      171           
  Lines       22585    22585           
  Branches     8559     8559           
=======================================
  Hits        18668    18668           
+ Misses       3136     3101   -35     
- Partials      781      816   +35     
Flag Coverage Δ
alpine317 72.72% <ø> (ø)
fedora37 72.73% <ø> (ø)
macos-12 61.50% <ø> (ø)
macos-13 60.55% <ø> (ø)
macos-14 60.55% <ø> (+<0.01%) ⬆️
mingw32 70.69% <ø> (ø)
mingw64 70.69% <ø> (ø)
npcap 83.91% <ø> (ø)
rhel93 72.74% <ø> (+0.04%) ⬆️
ubuntu1804 75.25% <ø> (ø)
ubuntu2004 73.69% <ø> (ø)
ubuntu2004-zstd 73.69% <ø> (?)
ubuntu2204 72.51% <ø> (-0.05%) ⬇️
ubuntu2204-icpx 59.03% <ø> (+<0.01%) ⬆️
unittest 82.65% <ø> (ø)
windows-2019 83.93% <ø> (ø)
windows-2022 83.93% <ø> (ø)
winpcap 83.89% <ø> (ø)
xdp 60.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seladb seladb marked this pull request as ready for review June 23, 2024 08:39
@seladb seladb changed the title Move Zstd CI from CirrusCI to GitHub Actions Move Zstd tests from CirrusCI to GitHub Actions Jun 23, 2024
# excludes ZSTD on Arm64
- arch: arm64
include:
- os-version: macos-12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no macos-14? maybe we should just maintain 13 and 14?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seladb I see, then don't we test zstd on macos 14 arm?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to test Zstd on all archs.

I tried on arm64 and it didn't work, probably because the Zstd version installed on this machine isn't compiled with arm64, so x86_64 is currently the only option

@tigercosmos tigercosmos merged commit 80dbe60 into dev Jun 23, 2024
38 checks passed
@tigercosmos tigercosmos deleted the move-zstd-to-gh-actions branch June 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants