Freebsd CI #1460
Freebsd CI #1460
Conversation
| cmake -S . -B Dist | ||
| cmake --build Dist -j$(sysctl -n hw.ncpu) | ||
|
|
||
| echo "Setting up the network interface for the tests" |
There was a problem hiding this comment.
since we cannot split the commands when we already in a run, just echoing the names.
note that we cannot have multiple runs, because the each run will init a new VM.
There was a problem hiding this comment.
note that we cannot have multiple runs, because the each run will init a new VM.
Why can't we split it into multiple runs? As far as I know, all run commands share the same environment.
One thing they might not share is the interface_name variable, but I think you can calculate it once and store it in $GITHUB_ENV: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files
I'd suggest splitting into multiple steps according to the echo commands you used
There was a problem hiding this comment.
since a "run" here actually go into the VM environment, so we must to stay in the same "run"
There was a problem hiding this comment.
got the error if we split to many runs: https://github.com/seladb/PcapPlusPlus/actions/runs/9638713557/job/26579832666?pr=1460
There was a problem hiding this comment.
since a "run" here actually go into the VM environment, so we must to stay in the same "run"
Yes you're right! this step sets up a FreeBSD VM so if we use it in multiple steps, multiple VMs will be created
|
@seladb please check. |
| cmake -S . -B Dist | ||
| cmake --build Dist -j$(sysctl -n hw.ncpu) | ||
|
|
||
| echo "Setting up the network interface for the tests" |
There was a problem hiding this comment.
note that we cannot have multiple runs, because the each run will init a new VM.
Why can't we split it into multiple runs? As far as I know, all run commands share the same environment.
One thing they might not share is the interface_name variable, but I think you can calculate it once and store it in $GITHUB_ENV: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files
I'd suggest splitting into multiple steps according to the echo commands you used
No description provided.