Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the target branch in the upload documentation step #1462

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

seladb
Copy link
Owner

@seladb seladb commented Jun 24, 2024

Build doxygen failed on master: https://github.com/seladb/PcapPlusPlus/actions/runs/9637853555/job/26577683049

This is because the default target branch in the target repo (PcapPlusPlus/pcapplusplus.github.io) is main and our docs repo still has master as its root branch. This PR specifies the target branch which should fix the issue

@seladb seladb marked this pull request as ready for review June 24, 2024 02:25
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (80dbe60) to head (9fd9f3c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1462   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         171      171           
  Lines       22585    22585           
  Branches     8559     8559           
=======================================
  Hits        18670    18670           
  Misses       3099     3099           
  Partials      816      816           
Flag Coverage Δ
alpine317 72.72% <ø> (ø)
fedora37 72.69% <ø> (-0.05%) ⬇️
macos-12 61.50% <ø> (ø)
macos-13 60.55% <ø> (ø)
macos-14 60.55% <ø> (ø)
mingw32 70.67% <ø> (-0.03%) ⬇️
mingw64 70.69% <ø> (ø)
npcap 83.91% <ø> (ø)
rhel93 72.74% <ø> (ø)
ubuntu1804 75.25% <ø> (-0.01%) ⬇️
ubuntu2004 73.69% <ø> (-0.01%) ⬇️
ubuntu2004-zstd 73.65% <ø> (-0.05%) ⬇️
ubuntu2204 72.55% <ø> (ø)
ubuntu2204-icpx 59.07% <ø> (-0.01%) ⬇️
unittest 82.66% <ø> (ø)
windows-2019 83.93% <ø> (ø)
windows-2022 83.93% <ø> (ø)
winpcap 83.90% <ø> (ø)
xdp 60.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigercosmos tigercosmos merged commit 2ef31f0 into dev Jun 24, 2024
38 checks passed
@tigercosmos tigercosmos deleted the fix-doxygen-branch branch June 24, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants