Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: github: save and restore ccache database #1492

Merged
merged 8 commits into from
Jul 19, 2024

Conversation

clementperon
Copy link
Collaborator

In order to speedup compilation save and restore ccache database

@clementperon clementperon requested a review from seladb as a code owner July 8, 2024 19:24
@clementperon clementperon changed the base branch from master to dev July 8, 2024 19:25
@clementperon clementperon force-pushed the cache_ccache branch 6 times, most recently from 30992e7 to 04b41ef Compare July 9, 2024 06:24
@tigercosmos
Copy link
Collaborator

cool! do you feel it faster?

@clementperon
Copy link
Collaborator Author

clementperon commented Jul 9, 2024

cool! do you feel it faster?

Yes, you can check it went from 3-4min to <1min

@seladb
Copy link
Owner

seladb commented Jul 17, 2024

@clementperon how does the compiler know to use ccache? Should we configure CMake with the ccache directory? 🤔

@clementperon
Copy link
Collaborator Author

clementperon commented Jul 17, 2024

@clementperon how does the compiler know to use ccache? Should we configure CMake with the ccache directory? 🤔

Because we merged this :)
#1483

@tigercosmos
Copy link
Collaborator

@clementperon Seems that there are conflicts. You may want to fix it.

@seladb
Copy link
Owner

seladb commented Jul 18, 2024

@clementperon how does the compiler know to use ccache? Should we configure CMake with the ccache directory? 🤔

Because we merged this :) #1483

But how does ccache know to use the ${{ github.workspace }}/.ccache directory to get the cached data? Is it the default directory?

@clementperon
Copy link
Collaborator Author

@clementperon how does the compiler know to use ccache? Should we configure CMake with the ccache directory? 🤔

Because we merged this :) #1483

But how does ccache know to use the ${{ github.workspace }}/.ccache directory to get the cached data? Is it the default directory?

Yes that's the default directory for Ccahe

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (d94d5a2) to head (1c3235b).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1492      +/-   ##
==========================================
- Coverage   82.10%   82.08%   -0.02%     
==========================================
  Files         273      273              
  Lines       43542    43539       -3     
  Branches     9014     9370     +356     
==========================================
- Hits        35749    35741       -8     
- Misses       6960     6983      +23     
+ Partials      833      815      -18     
Flag Coverage Δ
fedora39 74.20% <ø> (+0.01%) ⬆️
macos-12 80.30% <ø> (+0.01%) ⬆️
macos-13 79.68% <ø> (ø)
macos-14 79.60% <ø> (ø)
mingw32 70.67% <ø> (-0.02%) ⬇️
mingw64 70.68% <ø> (-0.02%) ⬇️
npcap 83.91% <ø> (-0.04%) ⬇️
rhel94 73.90% <ø> (-0.04%) ⬇️
ubuntu2004 57.24% <ø> (-16.96%) ⬇️
ubuntu2004-zstd 57.37% <ø> (-16.95%) ⬇️
ubuntu2204 73.87% <ø> (-0.01%) ⬇️
ubuntu2204-icpx 55.85% <ø> (-0.01%) ⬇️
unittest 82.08% <ø> (-0.02%) ⬇️
windows-2019 83.94% <ø> (-0.03%) ⬇️
windows-2022 83.96% <ø> (-0.02%) ⬇️
winpcap 83.93% <ø> (-0.01%) ⬇️
xdp 48.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigercosmos tigercosmos merged commit a605fa8 into seladb:dev Jul 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants