Replace variable length arrays with std::vector #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ol-imorozko
force-pushed
the
remove-vla
branch
from
225da90 to
df44982
Compare
Variable Length Arrays, while widely supported as compiler extensions are not part of the C++ standard. Replaced them with std::vector.
ol-imorozko
force-pushed
the
remove-vla
branch
from
df44982 to
6d12b6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1662 +/- ##
==========================================
- Coverage 83.16% 83.16% -0.01%
==========================================
Files 277 277
Lines 48193 48193
Branches 9966 9970 +4
==========================================
- Hits 40081 40078 -3
+ Misses 7234 7220 -14
- Partials 878 895 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dimi1010
approved these changes
Dec 18, 2024
egecetin
approved these changes
Dec 19, 2024
seladb
approved these changes
Dec 24, 2024
|
Thank you @ol-imorozko for this contribution, much appreciated! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable Length Arrays, while widely supported as compiler extensions are not part of the C++ standard. Replaced them with std::vector.
This PR extends Dimi1010's #1661