Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit configuration for gersemi #1670

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
exclude: '.*\.(pcap|pcapng|dat|txt)'
exclude: '.*\.(pcap|pcapng|dat)|(PacketExamples|PcapExamples|expected_output|pcap_examples).*\.txt'
fail_fast: false
repos:
- repo: local
Expand Down Expand Up @@ -41,6 +41,7 @@ repos:
rev: 0.17.1
hooks:
- id: gersemi
args: ["-c"]
- repo: https://github.com/codespell-project/codespell
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that gersemi run in check mode which returns 1 if any formatting required and 0 otherwise

rev: v2.3.0
hooks:
Expand Down
3 changes: 2 additions & 1 deletion 3rdParty/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ if(PCAPPP_INSTALL)
EXPORT PcapPlusPlusTargets
ARCHIVE DESTINATION ${PCAPPP_INSTALL_LIBDIR}
LIBRARY DESTINATION ${PCAPPP_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${PCAPPP_INSTALL_INCLUDEDIR})
PUBLIC_HEADER DESTINATION ${PCAPPP_INSTALL_INCLUDEDIR}
)
endif()
6 changes: 2 additions & 4 deletions 3rdParty/EndianPortable/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
add_library(EndianPortable INTERFACE)

target_include_directories(EndianPortable
INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/include)
target_include_directories(EndianPortable INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/include)

target_sources(EndianPortable
INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/include/EndianPortable.h)
target_sources(EndianPortable INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/include/EndianPortable.h)
6 changes: 2 additions & 4 deletions 3rdParty/Getopt-for-Visual-Studio/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
add_library(Getopt-for-Visual-Studio INTERFACE)

target_include_directories(Getopt-for-Visual-Studio
INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/)
target_include_directories(Getopt-for-Visual-Studio INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/)

target_sources(Getopt-for-Visual-Studio
INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/getopt.h)
target_sources(Getopt-for-Visual-Studio INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/getopt.h)
12 changes: 8 additions & 4 deletions 3rdParty/LightPcapNg/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/LightPcapNg/cmake/")
option(LIGHT_PCAPNG_ZSTD "Build with ZSTD compression support" OFF)

add_library(
light_pcapng OBJECT
light_pcapng
OBJECT
LightPcapNg/src/light_advanced.c
LightPcapNg/src/light_alloc.c
LightPcapNg/src/light_compression.c
Expand All @@ -20,16 +21,19 @@ add_library(
LightPcapNg/src/light_pcapng_ext.c
LightPcapNg/src/light_pcapng.c
LightPcapNg/src/light_platform.c
LightPcapNg/src/light_zstd_compression.c)
LightPcapNg/src/light_zstd_compression.c
)

target_compile_definitions(light_pcapng PUBLIC -DUNIVERSAL)

if(BUILD_SHARED_LIBS)
set_property(TARGET light_pcapng PROPERTY POSITION_INDEPENDENT_CODE ON)
endif()

target_include_directories(light_pcapng PUBLIC $<INSTALL_INTERFACE:include>
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/LightPcapNg/include>)
target_include_directories(
light_pcapng
PUBLIC $<INSTALL_INTERFACE:include> $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/LightPcapNg/include>
)

if(LIGHT_PCAPNG_ZSTD)
find_package(ZSTD)
Expand Down
150 changes: 66 additions & 84 deletions 3rdParty/LightPcapNg/LightPcapNg/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,84 +1,66 @@
cmake_minimum_required (VERSION 2.6)
project (light_pcapng C)
set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -I${CMAKE_CURRENT_SOURCE_DIR}/include/ -Wall -O2 -fPIC -DUNIVERSAL -g")

add_library (light_pcapng SHARED
src/light_io.c
src/light_pcapng.c
src/light_pcapng_cont.c
src/light_platform.c
src/light_manipulate.c
src/light_internal.c
src/light_alloc.c
src/light_advanced.c
src/light_option.c
src/light_pcapng_ext.c
)

add_library (light_pcapng_static STATIC
src/light_io.c
src/light_pcapng.c
src/light_pcapng_cont.c
src/light_platform.c
src/light_manipulate.c
src/light_internal.c
src/light_alloc.c
src/light_advanced.c
src/light_option.c
src/light_pcapng_ext.c
)

add_executable (test_read.test
src/tests/test_read.c
)
target_link_libraries(test_read.test light_pcapng_static)

add_executable (test_read_write.test
src/tests/test_read_write.c
)
target_link_libraries(test_read_write.test light_pcapng_static)

add_executable (test_mem.test
src/tests/test_mem.c
)
target_link_libraries(test_mem.test light_pcapng_static)

add_executable (test_histogram.test
src/tests/test_histogram.c
)
target_link_libraries(test_histogram.test light_pcapng_static)

add_executable (test_subcapture.test
src/tests/test_subcapture.c
)
target_link_libraries(test_subcapture.test light_pcapng_static)

add_executable (test_feature.test
src/tests/test_feature.c
)
target_link_libraries(test_feature.test light_pcapng_static)

add_executable (test_flow.test
src/tests/test_flow.c
)
target_link_libraries(test_flow.test light_pcapng_static)

add_executable (test_feature_advanced.test
src/tests/test_feature_advanced.c
)
target_link_libraries(test_feature_advanced.test light_pcapng_static dl)

add_executable (test_read_packets.test
src/tests/test_read_packets.c
)
target_link_libraries(test_read_packets.test light_pcapng_static)

add_executable (test_read_write_packets.test
src/tests/test_read_write_packets.c
)
target_link_libraries(test_read_write_packets.test light_pcapng_static)

add_executable (test_split.test
src/tests/test_split.c
)
target_link_libraries(test_split.test light_pcapng_static)
cmake_minimum_required(VERSION 2.6)
project(light_pcapng C)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -I${CMAKE_CURRENT_SOURCE_DIR}/include/ -Wall -O2 -fPIC -DUNIVERSAL -g")

add_library(
light_pcapng
SHARED
src/light_io.c
src/light_pcapng.c
src/light_pcapng_cont.c
src/light_platform.c
src/light_manipulate.c
src/light_internal.c
src/light_alloc.c
src/light_advanced.c
src/light_option.c
src/light_pcapng_ext.c
)

add_library(
light_pcapng_static
STATIC
src/light_io.c
src/light_pcapng.c
src/light_pcapng_cont.c
src/light_platform.c
src/light_manipulate.c
src/light_internal.c
src/light_alloc.c
src/light_advanced.c
src/light_option.c
src/light_pcapng_ext.c
)

add_executable(test_read.test src/tests/test_read.c)
target_link_libraries(test_read.test light_pcapng_static)

add_executable(test_read_write.test src/tests/test_read_write.c)
target_link_libraries(test_read_write.test light_pcapng_static)

add_executable(test_mem.test src/tests/test_mem.c)
target_link_libraries(test_mem.test light_pcapng_static)

add_executable(test_histogram.test src/tests/test_histogram.c)
target_link_libraries(test_histogram.test light_pcapng_static)

add_executable(test_subcapture.test src/tests/test_subcapture.c)
target_link_libraries(test_subcapture.test light_pcapng_static)

add_executable(test_feature.test src/tests/test_feature.c)
target_link_libraries(test_feature.test light_pcapng_static)

add_executable(test_flow.test src/tests/test_flow.c)
target_link_libraries(test_flow.test light_pcapng_static)

add_executable(test_feature_advanced.test src/tests/test_feature_advanced.c)
target_link_libraries(test_feature_advanced.test light_pcapng_static dl)

add_executable(test_read_packets.test src/tests/test_read_packets.c)
target_link_libraries(test_read_packets.test light_pcapng_static)

add_executable(test_read_write_packets.test src/tests/test_read_write_packets.c)
target_link_libraries(test_read_write_packets.test light_pcapng_static)

add_executable(test_split.test src/tests/test_split.c)
target_link_libraries(test_split.test light_pcapng_static)
2 changes: 1 addition & 1 deletion 3rdParty/LightPcapNg/LightPcapNg/LICENSE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
SOFTWARE.
7 changes: 3 additions & 4 deletions 3rdParty/MemPlumber/MemPlumber/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
endif()

# Build options
option(MEMPLUMBER_COLLECT_STATIC_VAR_DATA
"Collect data also on static variable memory allocation" OFF)
option(MEMPLUMBER_COLLECT_STATIC_VAR_DATA "Collect data also on static variable memory allocation" OFF)
option(MEMPLUMBER_DISABLE_BACKTRACE "Disable backtrace" OFF)
option(MEMPLUMBER_BUILD_TESTS "Build Tests" ${MEMPLUMBER_MAIN_PROJECT})
option(MEMPLUMBER_BUILD_EXAMPLES "Build Examples" ${MEMPLUMBER_MAIN_PROJECT})
Expand All @@ -37,11 +36,11 @@ if(MEMPLUMBER_DISABLE_BACKTRACE)
add_definitions(-DDISABLE_BACKTRACE)
endif()

if (MEMPLUMBER_BUILD_TESTS)
if(MEMPLUMBER_BUILD_TESTS)
enable_testing()
add_subdirectory(Tests)
endif()

if (MEMPLUMBER_BUILD_EXAMPLES)
if(MEMPLUMBER_BUILD_EXAMPLES)
add_subdirectory(Examples)
endif()
38 changes: 13 additions & 25 deletions 3rdParty/MemPlumber/MemPlumber/Examples/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,25 +1,13 @@
cmake_minimum_required (VERSION 3.0)

add_executable(basic-example
basic-example.cpp
)

target_link_libraries(basic-example PUBLIC
memplumber
)

add_executable(static-example
static-example.cpp
)

target_link_libraries(static-example PUBLIC
memplumber
)

add_executable(dump-to-file-example
dump-to-file-example.cpp
)

target_link_libraries(dump-to-file-example PUBLIC
memplumber
)
cmake_minimum_required(VERSION 3.0)

add_executable(basic-example basic-example.cpp)

target_link_libraries(basic-example PUBLIC memplumber)

add_executable(static-example static-example.cpp)

target_link_libraries(static-example PUBLIC memplumber)

add_executable(dump-to-file-example dump-to-file-example.cpp)

target_link_libraries(dump-to-file-example PUBLIC memplumber)
Loading
Loading